Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import startMigrationDarkIcon from './images/start_migration_icon_dark.png';
export const startMigrationCardConfig: OnboardingCardConfig<StartMigrationCardMetadata> = {
id: OnboardingCardId.siemMigrationsRules,
title: START_MIGRATION_CARD_TITLE,
badge: 'tech_preview',
icon: startMigrationIcon,
iconDark: startMigrationDarkIcon,
Component: React.lazy(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,4 @@ export const siemMigrationsLinks: LinkItem = {
skipUrlState: true,
hideTimeline: true,
hideWhenExperimentalKey: 'siemMigrationsDisabled',
isBeta: true,
betaOptions: {
text: i18n.translate('xpack.securitySolution.appLinks.siemMigrationsRules.badge', {
defaultMessage: 'Technical Preview',
}),
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export const AuthorFilterButton: React.FC<AuthorFilterButtonProps> = React.memo(
}}
isSelected={isPopoverOpen}
hasActiveFilters={author !== undefined}
numActiveFilters={author ? 1 : 0}
data-test-subj="authorFilterButton"
>
{i18n.AUTHOR_BUTTON_TITLE}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const StatusFilterButton: React.FC<StatusFilterButtonProps> = React.memo(
}}
isSelected={isPopoverOpen}
hasActiveFilters={status !== undefined}
numActiveFilters={status ? 1 : 0}
data-test-subj="statusFilterButton"
>
{i18n.STATUS_BUTTON_TITLE}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
} from '@elastic/eui';
import React, { useCallback, useMemo, useState } from 'react';

import type { RuleMigrationFilters } from '../../../../../common/siem_migrations/types';
import { useVisibility } from '../../../../common/hooks/use_visibility';
import type { RelatedIntegration, RuleResponse } from '../../../../../common/api/detection_engine';
import { isMigrationPrebuiltRule } from '../../../../../common/siem_migrations/rules/utils';
Expand Down Expand Up @@ -95,6 +96,11 @@ export const MigrationRulesTable: React.FC<MigrationRulesTableProps> = React.mem
const { data: prebuiltRules = {}, isLoading: isPrebuiltRulesLoading } =
useGetMigrationPrebuiltRules(migrationId);

const filters = useMemo<RuleMigrationFilters>(
() => ({ searchTerm, ...convertFilterOptions(filterOptions) }),
[searchTerm, filterOptions]
);

const {
data: { migrationRules, total } = { migrationRules: [], total: 0 },
isLoading: isDataLoading,
Expand All @@ -104,10 +110,7 @@ export const MigrationRulesTable: React.FC<MigrationRulesTableProps> = React.mem
perPage: pageSize,
sortField,
sortDirection,
filters: {
searchTerm,
...convertFilterOptions(filterOptions),
},
filters,
});

const [selectedMigrationRules, setSelectedMigrationRules] = useState<RuleMigrationRule[]>([]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@

import React, { useCallback, useEffect, useMemo } from 'react';

import { EuiSkeletonLoading, EuiSkeletonText, EuiSkeletonTitle, EuiSpacer } from '@elastic/eui';
import {
EuiSkeletonLoading,
EuiSkeletonText,
EuiSkeletonTitle,
EuiSpacer,
EuiTitle,
} from '@elastic/eui';
import type { RouteComponentProps } from 'react-router-dom';
import type { RelatedIntegration } from '../../../../common/api/detection_engine';
import { SiemMigrationTaskStatus } from '../../../../common/siem_migrations/constants';
Expand All @@ -28,9 +34,9 @@ import { MigrationProgressPanel } from '../components/migration_status_panels/mi
import { useInvalidateGetMigrationRules } from '../logic/use_get_migration_rules';
import { useInvalidateGetMigrationTranslationStats } from '../logic/use_get_migration_translation_stats';
import { useGetIntegrations } from '../service/hooks/use_get_integrations';
import { PageTitle } from './page_title';
import { RuleMigrationsUploadMissingPanel } from '../components/migration_status_panels/upload_missing_panel';
import { EmptyMigrationRulesPage } from './empty';
import * as i18n from './translations';

export type MigrationRulesPageProps = RouteComponentProps<{ migrationId?: string }>;

Expand Down Expand Up @@ -88,8 +94,6 @@ export const MigrationRulesPage: React.FC<MigrationRulesPageProps> = React.memo(
refreshStats,
]);

const pageTitle = useMemo(() => <PageTitle />, []);

const content = useMemo(() => {
if (ruleMigrationsStats.length === 0 && !migrationId) {
return <EmptyMigrationRulesPage />;
Expand Down Expand Up @@ -133,7 +137,14 @@ export const MigrationRulesPage: React.FC<MigrationRulesPageProps> = React.memo(

return (
<SecuritySolutionPageWrapper>
<HeaderPage title={pageTitle} border>
<HeaderPage
title={
<EuiTitle data-test-subj="siemMigrationsPageTitle" size="l">
<h1>{i18n.PAGE_TITLE}</h1>
</EuiTitle>
}
border
>
<HeaderButtons
ruleMigrationsStats={ruleMigrationsStats}
selectedMigrationId={migrationId}
Expand Down

This file was deleted.