-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Response Ops] Fix cases action owner on o11y serverless project #224537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jcger
merged 18 commits into
elastic:main
from
jcger:issue-186270-case-action-creates-stack-cases-bug-o11y
Jun 27, 2025
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f1cdcca
first commit
jcger b954445
restore minor irrelevant changes
jcger 7c9055b
rename and fix test
jcger 00f9c4c
fix type
jcger f088cb1
test
jcger 2ba1019
Merge branch 'main' into issue-186270-case-action-creates-stack-cases…
jcger 8c21cc9
Merge branch 'main' of github.com:jcger/kibana into issue-186270-case…
jcger 1fdeb87
use reliable isServerless way
jcger 12edd2f
Merge branch 'main' of github.com:jcger/kibana into issue-186270-case…
jcger 798cda5
Update x-pack/platform/plugins/shared/cases/common/utils/owner.test.ts
jcger f2678ba
Update x-pack/platform/plugins/shared/cases/common/utils/owner.test.ts
jcger fafe586
Update x-pack/platform/plugins/shared/cases/common/utils/owner.test.ts
jcger 51e893a
pr review
jcger 04c8fee
Merge branch 'main' into issue-186270-case-action-creates-stack-cases…
jcger f78bc10
fix test
jcger e83f745
Merge branch 'issue-186270-case-action-creates-stack-cases-bug-o11y' …
jcger 4e6626c
Merge branch 'main' into issue-186270-case-action-creates-stack-cases…
jcger 62673cd
Merge branch 'main' into issue-186270-case-action-creates-stack-cases…
jcger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please add a similar test, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting how this does not create circular dependencies. It also seems that this is only used to construct the types. Could we just create the union manually and add
esandchatto the list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this to be done in a follow-up PR, I'll create the GH issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening an issue only for adding two variables seems like an overkill. Either we do it know or we do not do it at all. Up to you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't know how to fill everything in
for
esandchat. Maybe you are talking about something else?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I was only suggested to add them in
SERVERLESS_PROJECT_TYPES. Not to fill theOWNER_INFOwith the extra information. But you have a point, better to leave it as it is.