[APM] integration new tail sampling settings#224479
Merged
cauemarcondes merged 1 commit intoelastic:mainfrom Jun 19, 2025
Merged
[APM] integration new tail sampling settings#224479cauemarcondes merged 1 commit intoelastic:mainfrom
cauemarcondes merged 1 commit intoelastic:mainfrom
Conversation
cauemarcondes
added
release_note:enhancement
backport:version
botelastic
bot
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
isaacaflores2
approved these changes
Jun 18, 2025
|
@cauemarcondes Will the discard on write failure toggle be set to false by default? Just double checking since my guess is you set it to true before you took the screenshot |
Contributor
Author
yes, it'll use wherever is defined on the setting definition. Indeed I took a screenshot after enabling it manually. |
carsonip
approved these changes
Jun 19, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15759545719 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 19, 2025
closes elastic#219303 closes elastic#221441 New settings: - `tail_sampling_ttl` - `tail_sampling_discard_on_write_failure` <img width="728" alt="Screenshot 2025-06-18 at 13 06 29" src="https://github.com/user-attachments/assets/dec21e4f-a6f8-411e-aadd-c96ab1186a6c" /> (cherry picked from commit f857b34)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
7 tasks
kibanamachine
added a commit
that referenced
this pull request
Jun 19, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[APM] integration new tail sampling settings (#224479)](#224479) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-19T13:52:48Z","message":"[APM] integration new tail sampling settings (#224479)\n\ncloses https://github.com/elastic/kibana/issues/219303\ncloses https://github.com/elastic/kibana/issues/221441\n\nNew settings:\n- `tail_sampling_ttl`\n- `tail_sampling_discard_on_write_failure`\n\n<img width=\"728\" alt=\"Screenshot 2025-06-18 at 13 06 29\"\nsrc=\"https://github.com/user-attachments/assets/dec21e4f-a6f8-411e-aadd-c96ab1186a6c\"\n/>","sha":"f857b34115cb07c77bfdd8634f2e2cc7ee91d9ba","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:obs-ux-infra_services","backport:version","v9.1.0","v8.19.0"],"title":"[APM] integration new tail sampling settings","number":224479,"url":"https://github.com/elastic/kibana/pull/224479","mergeCommit":{"message":"[APM] integration new tail sampling settings (#224479)\n\ncloses https://github.com/elastic/kibana/issues/219303\ncloses https://github.com/elastic/kibana/issues/221441\n\nNew settings:\n- `tail_sampling_ttl`\n- `tail_sampling_discard_on_write_failure`\n\n<img width=\"728\" alt=\"Screenshot 2025-06-18 at 13 06 29\"\nsrc=\"https://github.com/user-attachments/assets/dec21e4f-a6f8-411e-aadd-c96ab1186a6c\"\n/>","sha":"f857b34115cb07c77bfdd8634f2e2cc7ee91d9ba"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224479","number":224479,"mergeCommit":{"message":"[APM] integration new tail sampling settings (#224479)\n\ncloses https://github.com/elastic/kibana/issues/219303\ncloses https://github.com/elastic/kibana/issues/221441\n\nNew settings:\n- `tail_sampling_ttl`\n- `tail_sampling_discard_on_write_failure`\n\n<img width=\"728\" alt=\"Screenshot 2025-06-18 at 13 06 29\"\nsrc=\"https://github.com/user-attachments/assets/dec21e4f-a6f8-411e-aadd-c96ab1186a6c\"\n/>","sha":"f857b34115cb07c77bfdd8634f2e2cc7ee91d9ba"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
|
Tested manually:
- Observe correct output in Discovery
- Repeat with discard on write failure **enabled**
- Observe correct result in Discovery
|
This was referenced Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #219303
closes #221441
New settings:
tail_sampling_ttltail_sampling_discard_on_write_failure