Skip to content

[Streams 🌊] Make management view the main page for individual stream #224461

Merged
tonyghiani merged 13 commits intoelastic:mainfrom
tonyghiani:329-individual-streams-management-view
Jun 19, 2025
Merged

[Streams 🌊] Make management view the main page for individual stream #224461
tonyghiani merged 13 commits intoelastic:mainfrom
tonyghiani:329-individual-streams-management-view

Conversation

@tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Jun 18, 2025

📓 Summary

Closes https://github.com/elastic/streams-program/issues/329

Implement all necessary changes to make the management page the primary page when landing on a stream detail.

Screen.Recording.2025-06-18.at.17.49.40.mov

@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project v9.1.0 v8.19.0 labels Jun 18, 2025
@tonyghiani tonyghiani marked this pull request as ready for review June 18, 2025 15:51
@tonyghiani tonyghiani requested review from a team as code owners June 18, 2025 15:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@LucaWintergerst
Copy link
Contributor

LucaWintergerst commented Jun 18, 2025

@tonyghiani looks great and everything seems to work as expected. I also tested the Discover navigation.
The one thing that stands out is that the font size for the new size and docs numbers. It feels a bit too large, and checking it is a little larger than the Figma, but I'm not sure if that's on purpose
The Figma hat it as 20px (but I don't understand enough about how close the Figma would be to the final implementation or if it's my screen skewing that)

CleanShot 2025-06-18 at 19 43 56@2x

Either way not a blocker to get this merged :)

@tonyghiani
Copy link
Contributor Author

@LucaWintergerst good 👀 , the title needed to be sized differently, fixed!

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (config review only)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 509 442 -67

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 558.8KB 518.9KB -39.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streamsApp 10.6KB 10.5KB -152.0B

History

Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the breadcrumbs should be updated to remove the "Manage stream" part since there is no non-management view anymore:

Screenshot 2025-06-19 at 10 58 58

Comment on lines +89 to +91
css={css`
margin-bottom: -${euiTheme.size.s};
`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Need this negative margin to improve alignment with the button to open the retention modal.

@patpascal
Copy link
Contributor

Looks great @tonyghiani!. Not blocking, but I'm guessing we will need to add a bit of padding on the top of the block with the elements next to the title so they look centered.
image

If you make any more changes, could you change the EuiTabs size from L to M for me? If not, we'll leave it for the future.

Great work! And super fast!

@tonyghiani
Copy link
Contributor Author

Looks good, just the breadcrumbs should be updated to remove the "Manage stream" part since there is no non-management view anymore:

@thomheymann good one, I removed that!

@patpscal style changes applied as discussed offline!

Copy link
Contributor

@thomheymann thomheymann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@tonyghiani tonyghiani merged commit dbb72ee into elastic:main Jun 19, 2025
11 checks passed
@tonyghiani tonyghiani deleted the 329-individual-streams-management-view branch June 19, 2025 12:58
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15758441852

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 19, 2025
…lastic#224461)

## 📓 Summary

Closes elastic/streams-program#329

Implement all necessary changes to make the management page the primary
page when landing on a stream detail.

https://github.com/user-attachments/assets/0e21c1cb-ad07-4711-9bc0-8cbe0760faca

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit dbb72ee)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 20, 2025
…stream (#224461) (#224573)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Streams 🌊] Make management view the main page for individual stream
(#224461)](#224461)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2025-06-19T12:58:19Z","message":"[Streams
🌊] Make management view the main page for individual stream
(#224461)\n\n## 📓 Summary\n\nCloses
https://github.com/elastic/streams-program/issues/329\n\nImplement all
necessary changes to make the management page the primary\npage when
landing on a stream
detail.\n\n\nhttps://github.com/user-attachments/assets/0e21c1cb-ad07-4711-9bc0-8cbe0760faca\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"dbb72ee827bc99263e9d5e338388b31fbec18f9e","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"[Streams
🌊] Make management view the main page for individual stream
","number":224461,"url":"https://github.com/elastic/kibana/pull/224461","mergeCommit":{"message":"[Streams
🌊] Make management view the main page for individual stream
(#224461)\n\n## 📓 Summary\n\nCloses
https://github.com/elastic/streams-program/issues/329\n\nImplement all
necessary changes to make the management page the primary\npage when
landing on a stream
detail.\n\n\nhttps://github.com/user-attachments/assets/0e21c1cb-ad07-4711-9bc0-8cbe0760faca\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"dbb72ee827bc99263e9d5e338388b31fbec18f9e"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224461","number":224461,"mergeCommit":{"message":"[Streams
🌊] Make management view the main page for individual stream
(#224461)\n\n## 📓 Summary\n\nCloses
https://github.com/elastic/streams-program/issues/329\n\nImplement all
necessary changes to make the management page the primary\npage when
landing on a stream
detail.\n\n\nhttps://github.com/user-attachments/assets/0e21c1cb-ad07-4711-9bc0-8cbe0760faca\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"dbb72ee827bc99263e9d5e338388b31fbec18f9e"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
tonyghiani added a commit that referenced this pull request Jun 20, 2025
## 📓 Summary

Fix broken tests by #224461, which
were not executed during CI.
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
## 📓 Summary

Fix broken tests by elastic#224461, which
were not executed during CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants