Skip to content

Comments

[Discover][UnifiedSearch] POC to enable onQueryChange#224450

Closed
kertal wants to merge 6 commits intoelastic:mainfrom
kertal:discover-unifiedsearch-query-poc
Closed

[Discover][UnifiedSearch] POC to enable onQueryChange#224450
kertal wants to merge 6 commits intoelastic:mainfrom
kertal:discover-unifiedsearch-query-poc

Conversation

@kertal
Copy link
Member

@kertal kertal commented Jun 18, 2025

Summary

This is a currently failing attempt to make onQueryChange work in Kibana and to try to store the "dirty" edited state in Discover ... but it doesn't work, since the change seems not to arrive in the Editor?

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@kertal
Copy link
Member Author

kertal commented Jun 20, 2025

/ci

@kertal
Copy link
Member Author

kertal commented Jun 20, 2025

/ci

@kertal
Copy link
Member Author

kertal commented Jun 20, 2025

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 20, 2025

💔 Build Failed

Failed CI Steps

History

@kertal
Copy link
Member Author

kertal commented Jun 20, 2025

/ci ... Strange, i don't get type errors in the IDE locally

@kertal
Copy link
Member Author

kertal commented Jun 23, 2025

closing in favor of #224671

@kertal kertal closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants