[8.19] [Dashboard] Rewrite scss to emotion (#220520)#224434
Closed
mbondyra wants to merge 1 commit intoelastic:8.19from
Closed
[8.19] [Dashboard] Rewrite scss to emotion (#220520)#224434mbondyra wants to merge 1 commit intoelastic:8.19from
mbondyra wants to merge 1 commit intoelastic:8.19from
Conversation
## Summary Part of elastic#207852 II tested printed styles via exporting PDF and comparing. I prioritized classes over overly complex emotion props. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1dfc7ce) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_app/_dashboard_app.scss # src/platform/plugins/shared/dashboard/public/dashboard_renderer/viewport/_dashboard_viewport.scss # src/platform/plugins/shared/dashboard/public/dashboard_top_nav/_dashboard_top_nav.scss
ThomThomson
approved these changes
Jun 18, 2025
Contributor
💔 Build Failed
Failed CI StepsHistory |
Contributor
Author
|
This is probably not worth to be backported since the core changes weren't backported either https://github.com/elastic/kibana/pull/220494/files |
auto-merge was automatically disabled
June 18, 2025 14:45
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation