-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Fleet] Add license gate around agents automatic upgrades feature #224393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
| const { docLinks } = useStartServices(); | ||
| const granularPrivilegesCallout = useDismissableTour('GRANULAR_PRIVILEGES'); | ||
| const { enableAutomaticAgentUpgrades } = ExperimentalFeaturesService.get(); | ||
| const canEnableAutomaticAgentUpgrades = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we extract canEnableAutomaticAgentUpgrades as a function to reuse, similar to
kibana/x-pack/platform/plugins/shared/fleet/server/services/setup/fleet_synced_integrations.ts
Line 68 in 18f606e
| export const canEnableSyncIntegrations = () => { |
|
|
||
| if (!licenseService.isEnterprise()) { | ||
| throw new FleetUnauthorizedError( | ||
| 'Agents auto upgrades feature requires at least Enterprise license' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 'Agents auto upgrades feature requires at least Enterprise license' | |
| 'Auto-upgrade agents feature requires at least Enterprise license' |
|
Tested locally, looks good. |
juliaElastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @criamico |
…astic#224393) Add license gate around agents automatic upgrades feature: - Hide UI elements if license is less than Enterprise - hide Manage auto upgrade button in Agent policy details - Add license gate around API to update target versions in agent policy update - Add license gate around auto upgrade task With a basic license, try to access the agent auto upgrades feature and verify that is not available - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…re (#2… (#229752) Backport #224393 to 8.19 --------- Co-authored-by: Cristina Amico <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Summary
Add license gate around agents automatic upgrades feature:
Testing
With a basic license, try to access the agent auto upgrades feature and verify that is not available
Checklist