[ResponseOps] [Reporting] Allow users to see scheduled reports list #224354
Conversation
js-jankisalvi
added
the
Team:ResponseOps
umbopepato
force-pushed
the
scheduled-reports-ui
branch
from
d5b5d9a to
8abc15d
Compare
js-jankisalvi
force-pushed
the
scheduled-reports-tables
branch
from
1c7d9e0 to
d862ede
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
umbopepato
force-pushed
the
scheduled-reports-ui
branch
from
8abc15d to
4805aee
Compare
joana-cps
left a comment
joana-cps
left a comment
There was a problem hiding this comment.
We're missing the modal when disabling the schedule. Since this is a destructive action (the user can't enable it back) we need to make sure that we let the user know that.
Thanks @joana-cps! |
joana-cps
left a comment
joana-cps
left a comment
There was a problem hiding this comment.
Could you please change EuiAvatar to size s
| name: i18n.translate('xpack.reporting.schedules.tableColumns.reportTitle', { | ||
| defaultMessage: 'Title', | ||
| }), | ||
| width: '17%', |
There was a problem hiding this comment.
It feels like we could give more room for the title and balance out by removing a little bit from the schedule column
| }), | ||
| width: '17%', | ||
| render: (_title: string, item: ScheduledReportApiJSON) => ( | ||
| <EuiLink data-test-subj={`reportTitle`} onClick={() => setSelectedReport(item)}> |
There was a problem hiding this comment.
Clicking on it didn't work while doing QA. Not sure what to expect, looks like a link but it's updating a state here? Anyways, I couldn't see anything happen in the UI when clicking on it
There was a problem hiding this comment.
My bad, forgot add last change here. Working now. It opens view schedule config flyout
| @@ -0,0 +1,244 @@ | |||
| /* | |||
There was a problem hiding this comment.
I miss test to check the action items in a row
| }), | ||
| width: '20%', | ||
| render: (_nextRun: string) => { | ||
| return moment(_nextRun).format('YYYY-MM-DD @ hh:mm A'); |
There was a problem hiding this comment.
should we get the format from the global kibana settings?
| }, | ||
| }, | ||
| { | ||
| field: 'jobtype', |
There was a problem hiding this comment.
maybe rename fileType to match the name?
There was a problem hiding this comment.
this is the field name from api response, I can't change it
|
|
||
| let statusText: string; | ||
|
|
||
| switch (schedule.rrule.freq) { |
There was a problem hiding this comment.
I think you could have a mapping object outside of the render function with const translations = {[Frequency.DAILY]: i18n.translate...} so that all i18n calls are done once and not on every render. Here you could end up having const statusText = translations[schedule.rrule.freq]
💔 Build Failed
Failed CI StepsHistory
|
6 participants
Summary
Resolves #216322
Important
This PR is targeting the
scheduled-reports-uifeature branch, where the backend changes from thescheduled-reportsbranch are temporarily integrated while waiting for #221028 to be merged (see the squashed[TMP] ...commit message).This PR has few commits from #222135 to support view schedule config table action. Please ignore code changes in folders if you are already reviewing other PR.
src/platform/packages/private/kbn-reporting/public/share/share_context_menu,src/platform/packages/shared/response-ops/recurring-schedule-form,x-pack/platform/plugins/private/reporting/public/management/schemas,x-pack/platform/plugins/private/reporting/public/management/validatorsandxpack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/create_maintenance_windows_form.tsx.This PR adds new tabs
ExportsandSchedulesin Reporting section.Exportstab shows the list of all reports. Allows to open dashboard, download report and view report information.Schedulestab shows list of scheduled reports. Allows to disable schedule.Checklist
Check the PR satisfies following conditions.
What to test