[Security Solution] Fix default data view name mismatch#224333
Merged
christineweng merged 3 commits intoelastic:mainfrom Jun 24, 2025
Merged
[Security Solution] Fix default data view name mismatch#224333christineweng merged 3 commits intoelastic:mainfrom
christineweng merged 3 commits intoelastic:mainfrom
Conversation
christineweng
added
release_note:skip
christineweng
force-pushed
the
dp-default-dataview-label
branch
2 times, most recently
from
3641a61 to
e7bb93d
Compare
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
Contributor
|
When I run this branch locally I see the following options in the DataView manager UI Is this expected? |
Contributor
Author
|
@PhilippeOberti thanks for taking a look! Did you restart kibana after you pull the branch? I can see the name in my local instance Because the data view is created at app start and cached, if you have kibana previously running, the "new" data view with the proper name will not be created. |
Contributor
I see, a full refresh indeed did the trick. You might want to mention this in the PR description if other review the PR. |
PhilippeOberti
approved these changes
Jun 23, 2025
lgestc
approved these changes
Jun 24, 2025
christineweng
force-pushed
the
dp-default-dataview-label
branch
from
730bbf0 to
392f995
Compare
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
christineweng
force-pushed
the
dp-default-dataview-label
branch
from
302379b to
94c6536
Compare
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15861498735 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2025
## Summary Ref: elastic/security-team#12791 Enable `newDataViewPickerEnabled` and fresh kibana build ### Before  ### After Label is cut off in security pages because of the `Managed` label, will address this in a separate PR (likely in elastic#223451)   ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 26a14f3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 24, 2025
…) (#225174) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Fix default data view name mismatch (#224333)](#224333) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-24T21:05:52Z","message":"[Security Solution] Fix default data view name mismatch (#224333)\n\n## Summary\n\nRef: https://github.com/elastic/security-team/issues/12791\n\nEnable `newDataViewPickerEnabled` and fresh kibana build\n\n### Before\n\n\n\n\n### After\n\nLabel is cut off in security pages because of the `Managed` label, will\naddress this in a separate PR (likely in\nhttps://github.com//pull/223451)\n\n\n\n\n\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26a14f36bf8208caa8836b54607514810378372b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix default data view name mismatch","number":224333,"url":"https://github.com/elastic/kibana/pull/224333","mergeCommit":{"message":"[Security Solution] Fix default data view name mismatch (#224333)\n\n## Summary\n\nRef: https://github.com/elastic/security-team/issues/12791\n\nEnable `newDataViewPickerEnabled` and fresh kibana build\n\n### Before\n\n\n\n\n### After\n\nLabel is cut off in security pages because of the `Managed` label, will\naddress this in a separate PR (likely in\nhttps://github.com//pull/223451)\n\n\n\n\n\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26a14f36bf8208caa8836b54607514810378372b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224333","number":224333,"mergeCommit":{"message":"[Security Solution] Fix default data view name mismatch (#224333)\n\n## Summary\n\nRef: https://github.com/elastic/security-team/issues/12791\n\nEnable `newDataViewPickerEnabled` and fresh kibana build\n\n### Before\n\n\n\n\n### After\n\nLabel is cut off in security pages because of the `Managed` label, will\naddress this in a separate PR (likely in\nhttps://github.com//pull/223451)\n\n\n\n\n\n\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"26a14f36bf8208caa8836b54607514810378372b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Ref: elastic/security-team#12791 Enable `newDataViewPickerEnabled` and fresh kibana build ### Before  ### After Label is cut off in security pages because of the `Managed` label, will address this in a separate PR (likely in elastic#223451)   ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2 tasks
PhilippeOberti
added a commit
that referenced
this pull request
Oct 10, 2025
…and Security solution alerts data views when needed (#238354) ## Summary This PR aims at fixing a UI issue related to the data view picker changes we made recently in Security Solution. After enabling the `dataViewPickerEnabled` feature flag (see [this PR](#234101)) we realized that the `Security solution default` and `Security solution alerts` aren't displayed properly. This is only visible within an environment that had those data view existing before turning on the feature flag. Instead of showing `Security solution default` we show this <img width="562" height="366" alt="Screenshot 2025-10-09 at 4 10 40 PM" src="https://github.com/user-attachments/assets/3b59501e-f1ae-460d-b26c-b46f876ea772" /> And instead of showing `Security solution alerts` we show this <img width="558" height="404" alt="Screenshot 2025-10-09 at 4 10 18 PM" src="https://github.com/user-attachments/assets/f50a0eb7-a5f2-41e0-8018-28d9ddf92ee6" /> Looking at the Data Views screen under Stack Management, we indeed see that the names are matching what we see in the data view picker <img width="734" height="655" alt="Screenshot 2025-10-09 at 4 11 46 PM" src="https://github.com/user-attachments/assets/ebc743e8-91d9-4ac1-8992-85290db59f10" /> For the `Security solution default` data view, we added the name in [this PR](#224333). For the `Security solution alerts` data view, we created the alert index and the corresponding data view in [this PR](#224144). But we changed both names in [this PR](#231374) (from `Default security data view` to `Security solution default` and from `Security alert data view` to `Security solution alerts` respectively). This means that if one of these data views was created either without a name or with an old name, that name would persist and be visible within the new data view picker. ## The fix This PR makes a simple fix: if the names of the saved object differ from what we expect (only for the `default` and `alerts` data views), we update the saved object. Here's en example of the data view being updated after a refresh https://github.com/user-attachments/assets/4ef8c623-3e45-4a57-93bb-0464c3189f67 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2025
…and Security solution alerts data views when needed (elastic#238354) ## Summary This PR aims at fixing a UI issue related to the data view picker changes we made recently in Security Solution. After enabling the `dataViewPickerEnabled` feature flag (see [this PR](elastic#234101)) we realized that the `Security solution default` and `Security solution alerts` aren't displayed properly. This is only visible within an environment that had those data view existing before turning on the feature flag. Instead of showing `Security solution default` we show this <img width="562" height="366" alt="Screenshot 2025-10-09 at 4 10 40 PM" src="https://github.com/user-attachments/assets/3b59501e-f1ae-460d-b26c-b46f876ea772" /> And instead of showing `Security solution alerts` we show this <img width="558" height="404" alt="Screenshot 2025-10-09 at 4 10 18 PM" src="https://github.com/user-attachments/assets/f50a0eb7-a5f2-41e0-8018-28d9ddf92ee6" /> Looking at the Data Views screen under Stack Management, we indeed see that the names are matching what we see in the data view picker <img width="734" height="655" alt="Screenshot 2025-10-09 at 4 11 46 PM" src="https://github.com/user-attachments/assets/ebc743e8-91d9-4ac1-8992-85290db59f10" /> For the `Security solution default` data view, we added the name in [this PR](elastic#224333). For the `Security solution alerts` data view, we created the alert index and the corresponding data view in [this PR](elastic#224144). But we changed both names in [this PR](elastic#231374) (from `Default security data view` to `Security solution default` and from `Security alert data view` to `Security solution alerts` respectively). This means that if one of these data views was created either without a name or with an old name, that name would persist and be visible within the new data view picker. ## The fix This PR makes a simple fix: if the names of the saved object differ from what we expect (only for the `default` and `alerts` data views), we update the saved object. Here's en example of the data view being updated after a refresh https://github.com/user-attachments/assets/4ef8c623-3e45-4a57-93bb-0464c3189f67 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 4f30b77)
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…and Security solution alerts data views when needed (elastic#238354) ## Summary This PR aims at fixing a UI issue related to the data view picker changes we made recently in Security Solution. After enabling the `dataViewPickerEnabled` feature flag (see [this PR](elastic#234101)) we realized that the `Security solution default` and `Security solution alerts` aren't displayed properly. This is only visible within an environment that had those data view existing before turning on the feature flag. Instead of showing `Security solution default` we show this <img width="562" height="366" alt="Screenshot 2025-10-09 at 4 10 40 PM" src="https://github.com/user-attachments/assets/3b59501e-f1ae-460d-b26c-b46f876ea772" /> And instead of showing `Security solution alerts` we show this <img width="558" height="404" alt="Screenshot 2025-10-09 at 4 10 18 PM" src="https://github.com/user-attachments/assets/f50a0eb7-a5f2-41e0-8018-28d9ddf92ee6" /> Looking at the Data Views screen under Stack Management, we indeed see that the names are matching what we see in the data view picker <img width="734" height="655" alt="Screenshot 2025-10-09 at 4 11 46 PM" src="https://github.com/user-attachments/assets/ebc743e8-91d9-4ac1-8992-85290db59f10" /> For the `Security solution default` data view, we added the name in [this PR](elastic#224333). For the `Security solution alerts` data view, we created the alert index and the corresponding data view in [this PR](elastic#224144). But we changed both names in [this PR](elastic#231374) (from `Default security data view` to `Security solution default` and from `Security alert data view` to `Security solution alerts` respectively). This means that if one of these data views was created either without a name or with an old name, that name would persist and be visible within the new data view picker. ## The fix This PR makes a simple fix: if the names of the saved object differ from what we expect (only for the `default` and `alerts` data views), we update the saved object. Here's en example of the data view being updated after a refresh https://github.com/user-attachments/assets/4ef8c623-3e45-4a57-93bb-0464c3189f67 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…and Security solution alerts data views when needed (elastic#238354) ## Summary This PR aims at fixing a UI issue related to the data view picker changes we made recently in Security Solution. After enabling the `dataViewPickerEnabled` feature flag (see [this PR](elastic#234101)) we realized that the `Security solution default` and `Security solution alerts` aren't displayed properly. This is only visible within an environment that had those data view existing before turning on the feature flag. Instead of showing `Security solution default` we show this <img width="562" height="366" alt="Screenshot 2025-10-09 at 4 10 40 PM" src="https://github.com/user-attachments/assets/3b59501e-f1ae-460d-b26c-b46f876ea772" /> And instead of showing `Security solution alerts` we show this <img width="558" height="404" alt="Screenshot 2025-10-09 at 4 10 18 PM" src="https://github.com/user-attachments/assets/f50a0eb7-a5f2-41e0-8018-28d9ddf92ee6" /> Looking at the Data Views screen under Stack Management, we indeed see that the names are matching what we see in the data view picker <img width="734" height="655" alt="Screenshot 2025-10-09 at 4 11 46 PM" src="https://github.com/user-attachments/assets/ebc743e8-91d9-4ac1-8992-85290db59f10" /> For the `Security solution default` data view, we added the name in [this PR](elastic#224333). For the `Security solution alerts` data view, we created the alert index and the corresponding data view in [this PR](elastic#224144). But we changed both names in [this PR](elastic#231374) (from `Default security data view` to `Security solution default` and from `Security alert data view` to `Security solution alerts` respectively). This means that if one of these data views was created either without a name or with an old name, that name would persist and be visible within the new data view picker. ## The fix This PR makes a simple fix: if the names of the saved object differ from what we expect (only for the `default` and `alerts` data views), we update the saved object. Here's en example of the data view being updated after a refresh https://github.com/user-attachments/assets/4ef8c623-3e45-4a57-93bb-0464c3189f67 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…and Security solution alerts data views when needed (elastic#238354) ## Summary This PR aims at fixing a UI issue related to the data view picker changes we made recently in Security Solution. After enabling the `dataViewPickerEnabled` feature flag (see [this PR](elastic#234101)) we realized that the `Security solution default` and `Security solution alerts` aren't displayed properly. This is only visible within an environment that had those data view existing before turning on the feature flag. Instead of showing `Security solution default` we show this <img width="562" height="366" alt="Screenshot 2025-10-09 at 4 10 40 PM" src="https://github.com/user-attachments/assets/3b59501e-f1ae-460d-b26c-b46f876ea772" /> And instead of showing `Security solution alerts` we show this <img width="558" height="404" alt="Screenshot 2025-10-09 at 4 10 18 PM" src="https://github.com/user-attachments/assets/f50a0eb7-a5f2-41e0-8018-28d9ddf92ee6" /> Looking at the Data Views screen under Stack Management, we indeed see that the names are matching what we see in the data view picker <img width="734" height="655" alt="Screenshot 2025-10-09 at 4 11 46 PM" src="https://github.com/user-attachments/assets/ebc743e8-91d9-4ac1-8992-85290db59f10" /> For the `Security solution default` data view, we added the name in [this PR](elastic#224333). For the `Security solution alerts` data view, we created the alert index and the corresponding data view in [this PR](elastic#224144). But we changed both names in [this PR](elastic#231374) (from `Default security data view` to `Security solution default` and from `Security alert data view` to `Security solution alerts` respectively). This means that if one of these data views was created either without a name or with an old name, that name would persist and be visible within the new data view picker. ## The fix This PR makes a simple fix: if the names of the saved object differ from what we expect (only for the `default` and `alerts` data views), we update the saved object. Here's en example of the data view being updated after a refresh https://github.com/user-attachments/assets/4ef8c623-3e45-4a57-93bb-0464c3189f67 ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref: https://github.com/elastic/security-team/issues/12791
Enable
newDataViewPickerEnabledand fresh kibana buildBefore
After
Label is cut off in security pages because of the
Managedlabel, will address this in a separate PR (likely in #223451)Checklist
release_note:*label is applied per the guidelines