Skip to content

[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab#224287

Merged
benakansara merged 3 commits intoelastic:mainfrom
benakansara:fix/alert-details-active-tab
Jun 23, 2025
Merged

[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab#224287
benakansara merged 3 commits intoelastic:mainfrom
benakansara:fix/alert-details-active-tab

Conversation

@benakansara
Copy link
Contributor

@benakansara benakansara commented Jun 17, 2025

Fixes tab selection issue when user opens alert details page from "Related alerts" tab. In this case, "Overview" tab should be selected by default. In other cases, tab Id passed from URL should be used otherwise default to "Overview".

@benakansara benakansara requested a review from a team as a code owner June 17, 2025 15:37
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jun 17, 2025
@benakansara benakansara self-assigned this Jun 17, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jun 17, 2025
@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v8.19.0 and removed author:obs-ux-management PRs authored by the obs ux management team labels Jun 17, 2025
@baileycash-elastic
Copy link
Contributor

I made a similar fix here though I never managed to get a review from response ops before going on PTO. Do you mind leaving your own comments on my implementation for learning purposes?

@benakansara benakansara enabled auto-merge (squash) June 23, 2025 16:46
@benakansara benakansara merged commit 4553774 into elastic:main Jun 23, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15832522900

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB -6.0B

History

cc @benakansara

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2025
…t from Related alerts tab (elastic#224287)

Fixes tab selection issue when user opens alert details page from
"Related alerts" tab. In this case, "Overview" tab should be selected by
default. In other cases, tab Id passed from URL should be used otherwise
default to "Overview".

(cherry picked from commit 4553774)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 23, 2025
…ew alert from Related alerts tab (#224287) (#224947)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Observabililty] [Alert details] Fix active tab when opening new
alert from Related alerts tab
(#224287)](#224287)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-23T18:48:04Z","message":"[Observabililty]
[Alert details] Fix active tab when opening new alert from Related
alerts tab (#224287)\n\nFixes tab selection issue when user opens alert
details page from\n\"Related alerts\" tab. In this case, \"Overview\"
tab should be selected by\ndefault. In other cases, tab Id passed from
URL should be used otherwise\ndefault to
\"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Observabililty]
[Alert details] Fix active tab when opening new alert from Related
alerts
tab","number":224287,"url":"https://github.com/elastic/kibana/pull/224287","mergeCommit":{"message":"[Observabililty]
[Alert details] Fix active tab when opening new alert from Related
alerts tab (#224287)\n\nFixes tab selection issue when user opens alert
details page from\n\"Related alerts\" tab. In this case, \"Overview\"
tab should be selected by\ndefault. In other cases, tab Id passed from
URL should be used otherwise\ndefault to
\"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224287","number":224287,"mergeCommit":{"message":"[Observabililty]
[Alert details] Fix active tab when opening new alert from Related
alerts tab (#224287)\n\nFixes tab selection issue when user opens alert
details page from\n\"Related alerts\" tab. In this case, \"Overview\"
tab should be selected by\ndefault. In other cases, tab Id passed from
URL should be used otherwise\ndefault to
\"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…t from Related alerts tab (elastic#224287)

Fixes tab selection issue when user opens alert details page from
"Related alerts" tab. In this case, "Overview" tab should be selected by
default. In other cases, tab Id passed from URL should be used otherwise
default to "Overview".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants