[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab#224287
Merged
benakansara merged 3 commits intoelastic:mainfrom Jun 23, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
|
I made a similar fix here though I never managed to get a review from response ops before going on PTO. Do you mind leaving your own comments on my implementation for learning purposes? |
baileycash-elastic
approved these changes
Jun 23, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15832522900 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @benakansara |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 23, 2025
…t from Related alerts tab (elastic#224287) Fixes tab selection issue when user opens alert details page from "Related alerts" tab. In this case, "Overview" tab should be selected by default. In other cases, tab Id passed from URL should be used otherwise default to "Overview". (cherry picked from commit 4553774)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 23, 2025
…ew alert from Related alerts tab (#224287) (#224947) # Backport This will backport the following commits from `main` to `8.19`: - [[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab (#224287)](#224287) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-23T18:48:04Z","message":"[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab (#224287)\n\nFixes tab selection issue when user opens alert details page from\n\"Related alerts\" tab. In this case, \"Overview\" tab should be selected by\ndefault. In other cases, tab Id passed from URL should be used otherwise\ndefault to \"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab","number":224287,"url":"https://github.com/elastic/kibana/pull/224287","mergeCommit":{"message":"[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab (#224287)\n\nFixes tab selection issue when user opens alert details page from\n\"Related alerts\" tab. In this case, \"Overview\" tab should be selected by\ndefault. In other cases, tab Id passed from URL should be used otherwise\ndefault to \"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224287","number":224287,"mergeCommit":{"message":"[Observabililty] [Alert details] Fix active tab when opening new alert from Related alerts tab (#224287)\n\nFixes tab selection issue when user opens alert details page from\n\"Related alerts\" tab. In this case, \"Overview\" tab should be selected by\ndefault. In other cases, tab Id passed from URL should be used otherwise\ndefault to \"Overview\".","sha":"4553774d5a3ed332be03eca6474208f157fd5b83"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
…t from Related alerts tab (elastic#224287) Fixes tab selection issue when user opens alert details page from "Related alerts" tab. In this case, "Overview" tab should be selected by default. In other cases, tab Id passed from URL should be used otherwise default to "Overview".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tab selection issue when user opens alert details page from "Related alerts" tab. In this case, "Overview" tab should be selected by default. In other cases, tab Id passed from URL should be used otherwise default to "Overview".