Skip to content

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 17, 2025

Note

This PR will be merged into a feature branch

Summary

Updating the list scheduled report API response to return payload and space_id. This allows generating links for the reporting UI.

last_run: string | undefined;
next_run: string | undefined;
notification: RawScheduledReport['notification'];
payload?: ReportApiJSON['payload'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payload includes the objectType field so removing the redundant top level object_type field

@ymao1 ymao1 self-assigned this Jun 17, 2025
@ymao1 ymao1 marked this pull request as ready for review June 17, 2025 13:58
@ymao1 ymao1 requested a review from a team as a code owner June 17, 2025 13:58
@ymao1 ymao1 requested a review from js-jankisalvi June 17, 2025 13:59
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ymao1 ymao1 merged commit 2d6e8be into elastic:scheduled-reports Jun 17, 2025
12 checks passed
@ymao1 ymao1 deleted the scheduled-reports-list branch June 17, 2025 16:30
ymao1 added a commit that referenced this pull request Jun 19, 2025
Resolves #216313

## Summary

This is a feature branch that contains the following commits. Each
individual linked PR contains a summary and verification instructions.

* Schedule API - #219771
* Scheduled report task runner -
#219770
* List and disable API - #220922
* Audit logging - #221846
* Send scheduled report emails -
#220539
* Commit to check license -
f5f9d9d
* Update to list API response format -
#224262

---------

Co-authored-by: Ersin Erdal <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ersin Erdal <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alexi Doak <[email protected]>
ymao1 added a commit to ymao1/kibana that referenced this pull request Jun 20, 2025
Resolves elastic#216313

## Summary

This is a feature branch that contains the following commits. Each
individual linked PR contains a summary and verification instructions.

* Schedule API - elastic#219771
* Scheduled report task runner -
elastic#219770
* List and disable API - elastic#220922
* Audit logging - elastic#221846
* Send scheduled report emails -
elastic#220539
* Commit to check license -
elastic@f5f9d9d
* Update to list API response format -
elastic#224262

---------

Co-authored-by: Ersin Erdal <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Ersin Erdal <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alexi Doak <[email protected]>
(cherry picked from commit a409627)

# Conflicts:
#	src/platform/packages/private/kbn-reporting/common/routes.ts
#	x-pack/platform/plugins/private/canvas/server/feature.test.ts
#	x-pack/platform/plugins/private/reporting/server/core.ts
#	x-pack/platform/plugins/private/reporting/server/features.ts
#	x-pack/platform/plugins/shared/features/server/__snapshots__/oss_features.test.ts.snap
#	x-pack/platform/test/api_integration/apis/features/features/features.ts
#	x-pack/test_serverless/api_integration/test_suites/chat/platform_security/authorization.ts
#	x-pack/test_serverless/api_integration/test_suites/observability/platform_security/authorization.ts
#	x-pack/test_serverless/api_integration/test_suites/search/platform_security/authorization.ts
#	x-pack/test_serverless/api_integration/test_suites/security/platform_security/authorization.ts
ymao1 added a commit that referenced this pull request Jun 23, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Response Ops][Reporting] Scheduled Reports
(#221028)](#221028)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T13:20:18Z","message":"[Response
Ops][Reporting] Scheduled Reports (#221028)\n\nResolves
https://github.com/elastic/kibana/issues/216313\n\n## Summary\n\nThis is
a feature branch that contains the following commits. Each\nindividual
linked PR contains a summary and verification instructions.\n\n*
Schedule API - https://github.com/elastic/kibana/pull/219771\n*
Scheduled report task runner
-\nhttps://github.com//pull/219770\n* List and disable API
- https://github.com/elastic/kibana/pull/220922\n* Audit logging -
https://github.com/elastic/kibana/pull/221846\n* Send scheduled report
emails -\nhttps://github.com//pull/220539\n* Commit to
check license
-\nhttps://github.com//pull/221028/commits/f5f9d9daedcd18447b6a02335a53631a44413788\n*
Update to list API response format
-\nhttps://github.com//pull/224262\n\n---------\n\nCo-authored-by:
Ersin Erdal <[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by: Ersin
Erdal <[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Alexi Doak
<[email protected]>","sha":"a409627765dfaf3d588c35a0d510b8d1857cd266","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:ResponseOps","release_note:feature","ci:cloud-deploy","ci:cloud-persist-deployment","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0"],"title":"[Response
Ops][Reporting] Scheduled
Reports","number":221028,"url":"https://github.com/elastic/kibana/pull/221028","mergeCommit":{"message":"[Response
Ops][Reporting] Scheduled Reports (#221028)\n\nResolves
https://github.com/elastic/kibana/issues/216313\n\n## Summary\n\nThis is
a feature branch that contains the following commits. Each\nindividual
linked PR contains a summary and verification instructions.\n\n*
Schedule API - https://github.com/elastic/kibana/pull/219771\n*
Scheduled report task runner
-\nhttps://github.com//pull/219770\n* List and disable API
- https://github.com/elastic/kibana/pull/220922\n* Audit logging -
https://github.com/elastic/kibana/pull/221846\n* Send scheduled report
emails -\nhttps://github.com//pull/220539\n* Commit to
check license
-\nhttps://github.com//pull/221028/commits/f5f9d9daedcd18447b6a02335a53631a44413788\n*
Update to list API response format
-\nhttps://github.com//pull/224262\n\n---------\n\nCo-authored-by:
Ersin Erdal <[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by: Ersin
Erdal <[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Alexi Doak
<[email protected]>","sha":"a409627765dfaf3d588c35a0d510b8d1857cd266"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221028","number":221028,"mergeCommit":{"message":"[Response
Ops][Reporting] Scheduled Reports (#221028)\n\nResolves
https://github.com/elastic/kibana/issues/216313\n\n## Summary\n\nThis is
a feature branch that contains the following commits. Each\nindividual
linked PR contains a summary and verification instructions.\n\n*
Schedule API - https://github.com/elastic/kibana/pull/219771\n*
Scheduled report task runner
-\nhttps://github.com//pull/219770\n* List and disable API
- https://github.com/elastic/kibana/pull/220922\n* Audit logging -
https://github.com/elastic/kibana/pull/221846\n* Send scheduled report
emails -\nhttps://github.com//pull/220539\n* Commit to
check license
-\nhttps://github.com//pull/221028/commits/f5f9d9daedcd18447b6a02335a53631a44413788\n*
Update to list API response format
-\nhttps://github.com//pull/224262\n\n---------\n\nCo-authored-by:
Ersin Erdal <[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by: Ersin
Erdal <[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>\nCo-authored-by: Alexi Doak
<[email protected]>","sha":"a409627765dfaf3d588c35a0d510b8d1857cd266"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants