Skip to content

[8.18] [ResponseOps][Cases]Allow dashes in host names in Observables (#219038) #224204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgianaonoleata1904 merged 1 commit into from
Jun 17, 2025
Merged

[8.18] [ResponseOps][Cases]Allow dashes in host names in Observables (#219038) #224204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ describe('genericValidator', () => {
} as Parameters<ValidationFunc>[0]);
expect(result).toBeUndefined();
});

it('should return undefined if the value contains dashes', () => {
const result = genericValidator({
value: 'valid-value',
path: 'generic',
} as Parameters<ValidationFunc>[0]);
expect(result).toBeUndefined();
});
});

describe('domainValidator', () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const normalizeValueType = (value: string): keyof typeof fieldsConfig.val
};

const DOMAIN_REGEX = /^(?!-)[A-Za-z0-9-]{1,63}(?<!-)\.[A-Za-z]{2,}$/;
const GENERIC_REGEX = /^[a-zA-Z0-9._:/\\]+$/;
const GENERIC_REGEX = /^[a-zA-Z0-9._:/\\-]+$/;

const notStringError = (path: string) => ({
code: 'ERR_NOT_STRING',
Expand Down