Skip to content

[Test retry service] Add initialDelay option#224156

Merged
Bamieh merged 9 commits intoelastic:mainfrom
Bamieh:initial_delay_retry
Jun 17, 2025
Merged

[Test retry service] Add initialDelay option#224156
Bamieh merged 9 commits intoelastic:mainfrom
Bamieh:initial_delay_retry

Conversation

@Bamieh
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh commented Jun 16, 2025 •
edited by kibanamachine
Loading

Summary

Add initialDelay option to the tryWithRetries retry service. This is a common usecase across Kibana where we'd need to wait a little bit before ES fully refreshes the indexed data to test a specific behavior. Added a test case to test the new flag as well.

The PR updates the UI counters test case as an example where i needed this to replace delay(..) with the initialDelay flag. (original PR #224151)

closes #98240

@Bamieh Bamieh added the release_note:skip Skip the PR/issue when compiling release notes label Jun 16, 2025
@Bamieh Bamieh requested a review from a team as a code owner June 16, 2025 22:07
@Bamieh Bamieh requested review from a team as code owners June 16, 2025 22:07
@Bamieh Bamieh mentioned this pull request Jun 16, 2025
Merged
dmlemeshko
dmlemeshko approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh Bamieh enabled auto-merge (squash) June 17, 2025 07:41
gsoldevila
gsoldevila approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only) - could we run an FTR runner pipeline to validate?

@Bamieh
Copy link
Copy Markdown
Contributor Author

Bamieh commented Jun 17, 2025

could we run an FTR runner pipeline to validate?
@gsoldevila

the changes for the ui counters are already tested and merged but here is a FTR runner run that wouldnt hurt :) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8388

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 17, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8388

[✅] src/platform/test/api_integration/config.js: 25/25 tests passed.

see run history

@Bamieh Bamieh merged commit e4749b0 into elastic:main Jun 17, 2025
11 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 17, 2025

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/15703819702

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 17, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ftr-common-functional-services 98 99 +1
Unknown metric groups

API count

id before after diff
@kbn/ftr-common-functional-services 123 124 +1

History

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2025
@Bamieh @kibanamachine
[Test retry service] Add initialDelay option (elastic#224156)
4ca818e 
## Summary

Add `initialDelay` option to the `tryWithRetries` retry service. This is
a common usecase across Kibana where we'd need to wait a little bit
before ES fully refreshes the indexed data to test a specific behavior.
Added a test case to test the new flag as well.

The PR updates the UI counters test case as an example where i needed
this to replace `delay(..)` with the `initialDelay` flag. (original PR
elastic#224151)

closes elastic#98240

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e4749b0)
@kibanamachine kibanamachine mentioned this pull request Jun 17, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 17, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- Upgrade Puppeteer to v24.10.1 (#223985)
❌ 8.18 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.18:
- Fix that gap can be stuck "in-progress" (#221473)
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Security Solution][Detection Engine] refactors ES|QL pagination in case of alerts deduplication (#217069)
- Add ecs@mappings component template to transform destination index template (#223878)
- [Custom threshold] Add grouping information for no data alerts (#224093)
- [Response Ops][Connectors] New xpack.actions.webhook.ssl.pfx.enabled config (#222507)
- Fix that gap can be stuck "in-progress" (#221473)
- [Response Ops][Alerting] Cannot read properties of undefined (reading 'getActiveCount') (#221799)
- [Unzyme] rewrite a few enzyme tests to rtl (#223410)
- [Discover] Fix isLogsDataSourceContext check for logs data source sub profiles (#223988)
- [Maps] [A11y] make the Add layer wizard unordered list (#223532)
- [Automatic Migration] Adds ability to change settings when re-processing Rule Migration (#222542)
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 224156

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 19, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 19, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @Bamieh

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 20, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @Bamieh

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 23, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @Bamieh

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 24, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @Bamieh

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 25, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @Bamieh

@Bamieh Bamieh removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-major labels Jun 26, 2025
kibanamachine added a commit that referenced this pull request Jun 26, 2025
@kibanamachine @Bamieh @elasticmachine
[9.0] [Test retry service] Add initialDelay option (#224156) (#224201)
dc06e5e 
# Backport

This will backport the following commits from `main` to `9.0`:
- [[Test retry service] Add initialDelay option
(#224156)](#224156)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ahmad
Bamieh","email":"ahmad.bamyeh@elastic.co"},"sourceCommit":{"committedDate":"2025-06-17T09:42:53Z","message":"[Test
retry service] Add initialDelay option (#224156)\n\n## Summary\n\nAdd
`initialDelay` option to the `tryWithRetries` retry service. This is\na
common usecase across Kibana where we'd need to wait a little
bit\nbefore ES fully refreshes the indexed data to test a specific
behavior.\nAdded a test case to test the new flag as well.\n\n\nThe PR
updates the UI counters test case as an example where i needed\nthis to
replace `delay(..)` with the `initialDelay` flag. (original
PR\nhttps://github.com//pull/224151)\n\ncloses
https://github.com/elastic/kibana/issues/98240\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e4749b02b85b6f90765d2bcfadfd54660c0cc651","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[Test
retry service] Add initialDelay
option","number":224156,"url":"https://github.com/elastic/kibana/pull/224156","mergeCommit":{"message":"[Test
retry service] Add initialDelay option (#224156)\n\n## Summary\n\nAdd
`initialDelay` option to the `tryWithRetries` retry service. This is\na
common usecase across Kibana where we'd need to wait a little
bit\nbefore ES fully refreshes the indexed data to test a specific
behavior.\nAdded a test case to test the new flag as well.\n\n\nThe PR
updates the UI counters test case as an example where i needed\nthis to
replace `delay(..)` with the `initialDelay` flag. (original
PR\nhttps://github.com//pull/224151)\n\ncloses
https://github.com/elastic/kibana/issues/98240\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e4749b02b85b6f90765d2bcfadfd54660c0cc651"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224156","number":224156,"mergeCommit":{"message":"[Test
retry service] Add initialDelay option (#224156)\n\n## Summary\n\nAdd
`initialDelay` option to the `tryWithRetries` retry service. This is\na
common usecase across Kibana where we'd need to wait a little
bit\nbefore ES fully refreshes the indexed data to test a specific
behavior.\nAdded a test case to test the new flag as well.\n\n\nThe PR
updates the UI counters test case as an example where i needed\nthis to
replace `delay(..)` with the `initialDelay` flag. (original
PR\nhttps://github.com//pull/224151)\n\ncloses
https://github.com/elastic/kibana/issues/98240\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"e4749b02b85b6f90765d2bcfadfd54660c0cc651"}}]}]
BACKPORT-->

---------

Co-authored-by: Ahmad Bamieh <ahmad.bamyeh@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
@Bamieh Bamieh deleted the initial_delay_retry branch June 26, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delanni delanni delanni approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes v9.0.4 v9.1.0

Projects

None yet

Milestone

No milestone

6 participants

@Bamieh @kibanamachine @elasticmachine @delanni @dmlemeshko @gsoldevila