-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Alert Details] Add investigation guide empty state #223974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
justinkambic
merged 12 commits into
elastic:main
from
justinkambic:222051/investigation-guide-empty-state
Jun 23, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
096defb
Allow edit flyout form to accept an initial step prop.
justinkambic e36427c
Refactor alert details edit rule flyout flow and reusue for investiga…
justinkambic 80d9d1a
Add badge to IG tab.
justinkambic 5b203f2
Create unit tests to cover `initialStep` prop.
justinkambic a4a2efb
Add unit tests for investigation guide component.
justinkambic a6f73e2
Merge remote-tracking branch 'upstream/main' into 222051/investigatio…
justinkambic ca41011
TEMP
justinkambic ab9d8af
Fix broken unit tests.
justinkambic 72c81c9
Fix mocks in test file.
justinkambic 52b58c1
Merge remote-tracking branch 'upstream/main' into 222051/investigatio…
justinkambic c159bc9
Add another assertion to test.
justinkambic 64059f7
Merge branch 'main' into 222051/investigation-guide-empty-state
justinkambic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...lugins/observability/public/pages/alert_details/components/AlertDetailsRuleFormFlyout.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { RuleFormFlyout } from '@kbn/response-ops-rule-form/flyout'; | ||
| import { RuleFormStepId } from '@kbn/response-ops-rule-form/src/constants'; | ||
| import type { Rule } from '@kbn/triggers-actions-ui-plugin/public'; | ||
| import { useKibana } from '../../../utils/kibana_react'; | ||
|
|
||
| export interface AlertDetailsRuleFormFlyoutBaseProps { | ||
| onUpdate?: () => void; | ||
| refetch: () => void; | ||
| rule?: Rule; | ||
| } | ||
|
|
||
| interface Props extends AlertDetailsRuleFormFlyoutBaseProps { | ||
| initialEditStep?: RuleFormStepId; | ||
| isRuleFormFlyoutOpen: boolean; | ||
| setIsRuleFormFlyoutOpen: React.Dispatch<boolean>; | ||
| rule: Rule; | ||
| } | ||
|
|
||
| export function AlertDetailsRuleFormFlyout({ | ||
| initialEditStep, | ||
| onUpdate, | ||
| refetch, | ||
| isRuleFormFlyoutOpen, | ||
| setIsRuleFormFlyoutOpen, | ||
| rule, | ||
| }: Props) { | ||
| const { services } = useKibana(); | ||
| if (!isRuleFormFlyoutOpen) return null; | ||
| const { | ||
| triggersActionsUi: { ruleTypeRegistry, actionTypeRegistry }, | ||
| } = services; | ||
| return ( | ||
| <RuleFormFlyout | ||
| plugins={{ ...services, ruleTypeRegistry, actionTypeRegistry }} | ||
| id={rule.id} | ||
| onCancel={() => { | ||
| setIsRuleFormFlyoutOpen(false); | ||
| }} | ||
| onSubmit={() => { | ||
| onUpdate?.(); | ||
| refetch(); | ||
| setIsRuleFormFlyoutOpen(false); | ||
| }} | ||
| initialEditStep={initialEditStep} | ||
| /> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier or something in Windsurf rearranged these dependencies, I don't know why.