Skip to content

Add ecs@mappings component template to transform destination index template #223878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxcold merged 3 commits into from
Jun 17, 2025
Merged

Add ecs@mappings component template to transform destination index template #223878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ffee45
add ecs@mappings component template to transform destination index te…
maxcold Jun 13, 2025
708675f
fix unit tests
maxcold Jun 13, 2025
36887ba
Merge branch 'main' into csp-add-ecs-mappings-to-transform-destination
maxcold Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions x-pack/platform/plugins/shared/fleet/server/services/epm/elasticsearch/transform/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ import { getInstallation } from '../../packages';
import { retryTransientEsErrors } from '../retry';
import { isUserSettingsTemplate } from '../template/utils';

import { MAX_CONCURRENT_TRANSFORMS_OPERATIONS } from '../../../../constants';
import {
MAX_CONCURRENT_TRANSFORMS_OPERATIONS,
STACK_COMPONENT_TEMPLATE_ECS_MAPPINGS,
} from '../../../../constants';

import { deleteTransforms } from './remove';
import { getDestinationIndexAliases } from './transform_utils';
Expand Down Expand Up @@ -579,7 +582,10 @@ const installTransformsAssets = async (
?.get('destinationIndex').index,
],
_meta: destinationIndexTemplate._meta,
composed_of: Object.keys(componentTemplates),
composed_of: [
...Object.keys(componentTemplates),
STACK_COMPONENT_TEMPLATE_ECS_MAPPINGS,
Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, is it expected that this change impacts all packages with transforms?

Copy link
Copy Markdown
Contributor Author

@maxcold maxcold Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we had a few discussions in the related threads:

It's an option to make this change opt-in through the package-spec, but no blockers were raised to make it happen for every transform

],
ignore_missing_component_templates:
Object.keys(componentTemplates).filter(isUserSettingsTemplate),
},
Expand Down
3 changes: 3 additions & 0 deletions ...tform/plugins/shared/fleet/server/services/epm/elasticsearch/transform/transforms.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ _meta:
'logs-endpoint.metadata_current-template@package',
'endpoint@custom',
'logs-endpoint.metadata_current-template@custom',
'ecs@mappings',
],
index_patterns: ['.metrics-endpoint.metadata_united_default'],
priority: 250,
Expand Down Expand Up @@ -676,6 +677,7 @@ _meta:
'logs-endpoint.metadata_current-template@package',
'endpoint@custom',
'logs-endpoint.metadata_current-template@custom',
'ecs@mappings',
],
index_patterns: ['.metrics-endpoint.metadata_united_default'],
priority: 250,
Expand Down Expand Up @@ -941,6 +943,7 @@ _meta:
'logs-endpoint.metadata_current-template@package',
'endpoint@custom',
'logs-endpoint.metadata_current-template@custom',
'ecs@mappings',
],
index_patterns: ['.metrics-endpoint.metadata_united_default'],
priority: 250,
Expand Down
Loading