Skip to content

[9.0] Revert "[ES|QL] Fix CSV report time range when exporting from Discover (#216792)" (#223249) #223344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davismcphee merged 1 commit into from
Jun 11, 2025
Merged

[9.0] Revert "[ES|QL] Fix CSV report time range when exporting from Discover (#216792)" (#223249) #223344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions ...shared/discover/public/application/main/components/top_nav/app_menu_actions/get_share.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,7 @@ export const getShareAppMenuItem = ({
},
sharingData: {
isTextBased: isEsqlMode,
locatorParams: [
{
id: locator.id,
params: isEsqlMode
? {
...params,
timeRange: timefilter.getAbsoluteTime(), // Will be used when generating CSV on server. See `filtersFromLocator`.
}
: params,
},
],
locatorParams: [{ id: locator.id, params }],
...searchSourceSharingData,
// CSV reports can be generated without a saved search so we provide a fallback title
title:
Expand Down
19 changes: 0 additions & 19 deletions x-pack/test/functional/apps/discover/group1/__snapshots__/reporting.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion x-pack/test/functional/apps/discover/group1/reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expectSnapshot(csvFile).toMatch();
});

it('generate a report using ES|QL for relative time range as absolute dates and time params', async () => {
// TODO: Adjust and unskip when we have full support for toggling relative/absolute time ranges through the export UI
// https://github.com/elastic/kibana/issues/223171
it.skip('generate a report using ES|QL for relative time range as absolute dates and time params', async () => {
const RECENT_DATA_INDEX_NAME = 'test_recent_data';
const RECENT_DOC_COUNT = 500;
const RECENT_DOC_END_DATE = moment().toISOString();
Expand Down