Skip to content

fix(streams): fix flakiness in scout test #223271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdelemme merged 7 commits into from
Jun 12, 2025
Merged

fix(streams): fix flakiness in scout test #223271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90e8ad9
disable wired streams test until we figure out flakiness issue
kdelemme Jun 10, 2025
0773936
fix: flakiness of scout test around schema editor
kdelemme Jun 10, 2025
5b6884a
Merge branch 'main' into streams/improve-scout-resilience
kdelemme Jun 10, 2025
af8d81f
Merge branch 'main' into streams/improve-scout-resilience
kdelemme Jun 11, 2025
fd3fcb0
run scout tests 10x times
dmlemeshko Jun 11, 2025
a1dcd4c
Merge branch 'main' into streams/improve-scout-resilience
dmlemeshko Jun 11, 2025
b7c6812
Revert "run scout tests 10x times"
kdelemme Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...form/plugins/shared/streams_app/public/components/data_management/schema_editor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export function SchemaEditor({
<Controls controls={controls} onChange={updateControls} onRefreshData={onRefreshData} />
)}
<FieldsTable
isLoading={isLoading ?? false}
controls={controls}
withToolbar={withToolbar}
defaultColumns={defaultColumns}
Expand Down
7 changes: 7 additions & 0 deletions ...hared/streams_app/public/components/data_management/schema_editor/schema_editor_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,15 @@ import { SchemaField } from './types';
import { FieldType } from './field_type';

export function FieldsTable({
isLoading,
controls,
defaultColumns,
fields,
stream,
withTableActions,
withToolbar,
}: {
isLoading: boolean;
controls: TControls;
defaultColumns: TableColumnName[];
fields: SchemaField[];
Expand Down Expand Up @@ -65,6 +67,11 @@ export function FieldsTable({

return (
<EuiDataGrid
data-test-subj={
isLoading
? 'streamsAppSchemaEditorFieldsTableLoading'
: 'streamsAppSchemaEditorFieldsTableLoaded'
}
aria-label={i18n.translate(
'xpack.streams.streamDetailSchemaEditor.fieldsTable.actionsTitle',
{ defaultMessage: 'Preview' }
Expand Down
2 changes: 1 addition & 1 deletion x-pack/platform/plugins/shared/streams_app/ui_tests/tests/classic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { testData, test } from '../fixtures';

const DATA_STREAM_NAME = 'my-data-stream';

test.describe('Classic Streams', { tag: ['@ess'] }, () => {
test.describe('Classic Streams', { tag: ['@ess', '@svlOblt'] }, () => {
test.beforeEach(async ({ kbnClient, esClient, browserAuth, pageObjects }) => {
await kbnClient.importExport.load(testData.KBN_ARCHIVES.DASHBOARD);
await esClient.indices.putIndexTemplate({
Expand Down
15 changes: 5 additions & 10 deletions x-pack/platform/plugins/shared/streams_app/ui_tests/tests/wired.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { expect } from '@kbn/scout';
import { testData, test } from '../fixtures';

test.describe.skip('Wired Streams', { tag: ['@ess'] }, () => {
test.describe('Wired Streams', { tag: ['@ess', '@svlOblt'] }, () => {
test.beforeEach(async ({ apiServices, kbnClient, browserAuth, pageObjects }) => {
await kbnClient.importExport.load(testData.KBN_ARCHIVES.DASHBOARD);
await apiServices.streams.enable();
Expand Down Expand Up @@ -70,16 +70,11 @@ test.describe.skip('Wired Streams', { tag: ['@ess'] }, () => {
await page.getByPlaceholder('Search...').fill('attributes');
await page.getByTestId('streamsAppContentRefreshButton').click();

const actionsButtons = page
await expect(page.getByTestId('streamsAppSchemaEditorFieldsTableLoaded')).toBeVisible();
await page
.getByRole('row', { name: 'attributes.custom_field' })
.getByTestId('streamsAppActionsButton');

await actionsButtons.focus();
await actionsButtons.click();

await expect(
page.getByTestId('contextMenuPanelTitle').getByText('Field actions')
).toBeVisible();
.getByTestId('streamsAppActionsButton')
.click();
await page.getByRole('button', { name: 'Map field' }).click();
await page.getByRole('combobox').selectOption('keyword');
await page.getByRole('button', { name: 'Save changes' }).click();
Expand Down