[8.19] [ResponseOps][MaintenanceWindows] Move recurring schedule form to dedicated package (#220535)#223203
Merged
umbopepato merged 3 commits intoelastic:8.19from Jun 10, 2025
Merged
Conversation
…icated package (elastic#220535) ## Summary Moves the recurring schedule (rrule) form from the Maintenance Windows form to a dedicated package. ## Implementation details ~~Because of the tight time constraints we have for this epic, I tried to change the recurring schedule form as little as possible, keeping the existing form-lib-based implementation and adding an intermediate layer to embed the editing UI in larger forms (i.e. MW form). While this is not particularly elegant, it allows us to build on top of an existing, tested codebase and to leverage form-lib's validation and state management capabilities.~~ ~~In the context of the MW form, the recurring schedule editor is treated as a single field. Value and error updates are synced through form-lib's field hook API:~~ https://github.com/elastic/kibana/blob/acd6a4823e5b9c53ae7cbed59a246972ab32cfe0/x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_field.tsx#L21-L34 ~~Errors are handled internally by the schedule editor, but must still be surfaced up to the parent form in order to have a consistent validity state (otherwise submits are not prevented even if errors are shown in the UI).~~ The recurring schedule form schema and form fields are exported to be reused in larger form-lib forms. ## References Closes elastic#219454 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 664a435) # Conflicts: # src/platform/packages/shared/response-ops/recurring-schedule-form/utils/convert_to_rrule.ts # src/platform/packages/shared/response-ops/recurring-schedule-form/utils/parse_schedule.ts # src/platform/packages/shared/response-ops/recurring-schedule-form/utils/recurring_summary.ts # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.test.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/recurring_schedule.test.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/recurring_schedule_form/recurring_schedule.tsx # x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/constants.ts
1 task
Contributor
💔 Build Failed
Failed CI StepsHistory
|
cnasikas
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation