[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression #223090
Merged
vitaliidm merged 120 commits intoelastic:mainfrom Jun 19, 2025
Merged
Conversation
# Conflicts: # x-pack/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.schema.yaml # x-pack/plugins/security_solution/public/common/lib/telemetry/constants.ts # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.gen.ts # x-pack/solutions/security/plugins/security_solution/common/constants.ts # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/bulk_actions/forms/alert_suppression_form.tsx # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/logic/bulk_actions/validations.ts
…com/vitaliidm/kibana into de_8_16/bulk-edit-alert-suppression
…aliidm/kibana into de_9_1/bulk-edit-suppression
…aliidm/kibana into de_9_1/bulk-edit-suppression
Contributor
Author
|
Thank you for review, @maximpn |
maximpn
approved these changes
Jun 17, 2025
Contributor
maximpn
left a comment
maximpn
left a comment
There was a problem hiding this comment.
@vitaliidm Thanks for addressing my comments and fixing the UI bug 🙏
# Conflicts: # oas_docs/output/kibana.serverless.yaml # oas_docs/output/kibana.yaml # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.test.ts # x-pack/solutions/security/plugins/security_solution/docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml # x-pack/solutions/security/plugins/security_solution/docs/openapi/serverless/security_solution_detections_api_2023_10_31.bundled.schema.yaml # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/api/rules/bulk_actions/route.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/rule_bulk_actions/trial_license_complete_tier/perform_bulk_action_dry_run.ts
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @vitaliidm |
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15760094832 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
vitaliidm
added a commit
to vitaliidm/kibana
that referenced
this pull request
Jun 19, 2025
…lert suppression (elastic#223090) ## Summary - addresses elastic/security-team#9190 (issue's description does not contain details, for product requirements refer to elastic/security-team#9190 (comment)) - adds simplified bulk editing, when user can only overwrite or remove alert suppression for multiple rules ### DEMO https://github.com/user-attachments/assets/88dc2953-e3fa-44c3-b896-ff533c66553f ### Feature flag ```yml xpack.securitySolution.enableExperimental: - bulkEditAlertSuppressionEnabled ``` ### Flaky test runner FTR - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360 Cypress - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361 ### Docs issue elastic/docs-content#1719 ### Test plan elastic/security-team#12813 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co> (cherry picked from commit 40dccf5) # Conflicts: # oas_docs/output/kibana.serverless.yaml # oas_docs/output/kibana.yaml # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.gen.ts # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.schema.yaml # x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/rule_management/bulk_actions/bulk_actions_route.test.ts # x-pack/solutions/security/plugins/security_solution/docs/openapi/ess/security_solution_detections_api_2023_10_31.bundled.schema.yaml # x-pack/solutions/security/plugins/security_solution/docs/openapi/serverless/security_solution_detections_api_2023_10_31.bundled.schema.yaml # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_responses.ts # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_management/api/rules/bulk_actions/route.ts # x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/rule_bulk_actions/trial_license_complete_tier/perform_bulk_action_dry_run.ts
vitaliidm
added a commit
that referenced
this pull request
Jun 20, 2025
…t for alert suppression (#223090) (#224595) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression (#223090)](#223090) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-19T14:20:12Z","message":"[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression (#223090)\n\n## Summary\n\n- addresses https://github.com/elastic/security-team/issues/9190\n(issue's description does not contain details, for product requirements\nrefer to\nhttps://github.com/elastic/security-team/issues/9190#issuecomment-2943723763)\n- adds simplified bulk editing, when user can only overwrite or remove\nalert suppression for multiple rules\n\n### DEMO\n\n\n\nhttps://github.com/user-attachments/assets/88dc2953-e3fa-44c3-b896-ff533c66553f\n\n### Feature flag\n\n```yml\nxpack.securitySolution.enableExperimental:\n - bulkEditAlertSuppressionEnabled\n```\n\n### Flaky test runner\n\nFTR -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360\nCypress -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361\n\n### Docs issue\n\nhttps://github.com/elastic/docs-content/issues/1719\n\n### Test plan\n\nhttps://github.com/elastic/security-team/pull/12813\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>","sha":"40dccf51a2ea3fd4e2b2b8b86564e669ad8896cb","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team: SecuritySolution","release_note:feature","Team:Detection Engine","backport:version","9.1 candidate","8.19 candidate","v9.1.0","v8.19.0"],"title":"[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression ","number":223090,"url":"https://github.com/elastic/kibana/pull/223090","mergeCommit":{"message":"[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression (#223090)\n\n## Summary\n\n- addresses https://github.com/elastic/security-team/issues/9190\n(issue's description does not contain details, for product requirements\nrefer to\nhttps://github.com/elastic/security-team/issues/9190#issuecomment-2943723763)\n- adds simplified bulk editing, when user can only overwrite or remove\nalert suppression for multiple rules\n\n### DEMO\n\n\n\nhttps://github.com/user-attachments/assets/88dc2953-e3fa-44c3-b896-ff533c66553f\n\n### Feature flag\n\n```yml\nxpack.securitySolution.enableExperimental:\n - bulkEditAlertSuppressionEnabled\n```\n\n### Flaky test runner\n\nFTR -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360\nCypress -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361\n\n### Docs issue\n\nhttps://github.com/elastic/docs-content/issues/1719\n\n### Test plan\n\nhttps://github.com/elastic/security-team/pull/12813\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>","sha":"40dccf51a2ea3fd4e2b2b8b86564e669ad8896cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223090","number":223090,"mergeCommit":{"message":"[Security Solution][Detection Engine] adds simplified bulk edit for alert suppression (#223090)\n\n## Summary\n\n- addresses https://github.com/elastic/security-team/issues/9190\n(issue's description does not contain details, for product requirements\nrefer to\nhttps://github.com/elastic/security-team/issues/9190#issuecomment-2943723763)\n- adds simplified bulk editing, when user can only overwrite or remove\nalert suppression for multiple rules\n\n### DEMO\n\n\n\nhttps://github.com/user-attachments/assets/88dc2953-e3fa-44c3-b896-ff533c66553f\n\n### Feature flag\n\n```yml\nxpack.securitySolution.enableExperimental:\n - bulkEditAlertSuppressionEnabled\n```\n\n### Flaky test runner\n\nFTR -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360\nCypress -\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361\n\n### Docs issue\n\nhttps://github.com/elastic/docs-content/issues/1719\n\n### Test plan\n\nhttps://github.com/elastic/security-team/pull/12813\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>","sha":"40dccf51a2ea3fd4e2b2b8b86564e669ad8896cb"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
…lert suppression (elastic#223090) ## Summary - addresses elastic/security-team#9190 (issue's description does not contain details, for product requirements refer to elastic/security-team#9190 (comment)) - adds simplified bulk editing, when user can only overwrite or remove alert suppression for multiple rules ### DEMO https://github.com/user-attachments/assets/88dc2953-e3fa-44c3-b896-ff533c66553f ### Feature flag ```yml xpack.securitySolution.enableExperimental: - bulkEditAlertSuppressionEnabled ``` ### Flaky test runner FTR - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360 Cypress - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361 ### Docs issue elastic/docs-content#1719 ### Test plan elastic/security-team#12813 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEMO
Screen.Recording.2025-06-09.at.17.28.54.mov
Feature flag
Flaky test runner
FTR - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8360
Cypress - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/8361
Docs issue
elastic/docs-content#1719
Test plan
https://github.com/elastic/security-team/pull/12813