Skip to content

[ES|QL] Moves the editor tests to react-testing library#222975

Merged
stratoula merged 1 commit intoelastic:mainfrom
stratoula:remove-enzyme-esql-codebase
Jun 6, 2025
Merged

[ES|QL] Moves the editor tests to react-testing library#222975
stratoula merged 1 commit intoelastic:mainfrom
stratoula:remove-enzyme-esql-codebase

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 6, 2025

Summary

Part of #222949

Goodby Enzyme

Checklist

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Jun 6, 2025
@stratoula stratoula changed the title [ES|QL] Moves the tests to react-testing library [ES|QL] Moves the editor tests to react-testing library Jun 6, 2025
@stratoula stratoula marked this pull request as ready for review June 6, 2025 12:54
@stratoula stratoula requested a review from a team as a code owner June 6, 2025 12:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Count of Enzyme imports

Enzyme is no longer supported, and we should switch to @testing-library/react instead.

id before after diff
@kbn/esql-editor 1 0 -1

@stratoula stratoula merged commit 7c94882 into elastic:main Jun 6, 2025
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15493524101

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 6, 2025
## Summary

Part of elastic#222949

Goodby Enzyme

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7c94882)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @stratoula

pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
## Summary

Part of elastic#222949

Goodby Enzyme

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @stratoula

kibanamachine added a commit that referenced this pull request Jun 12, 2025
…) (#223019)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Moves the editor tests to react-testing library
(#222975)](#222975)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-06-06T14:58:16Z","message":"[ES|QL]
Moves the editor tests to react-testing library (#222975)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/222949\n\nGoodby Enzyme\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7c948829c7112b23ef6d204d433fae1c8b86d6b2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Moves the editor tests to react-testing
library","number":222975,"url":"https://github.com/elastic/kibana/pull/222975","mergeCommit":{"message":"[ES|QL]
Moves the editor tests to react-testing library (#222975)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/222949\n\nGoodby Enzyme\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7c948829c7112b23ef6d204d433fae1c8b86d6b2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222975","number":222975,"mergeCommit":{"message":"[ES|QL]
Moves the editor tests to react-testing library (#222975)\n\n##
Summary\n\nPart of
https://github.com/elastic/kibana/issues/222949\n\nGoodby Enzyme\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7c948829c7112b23ef6d204d433fae1c8b86d6b2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2025
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
## Summary

Part of elastic#222949

Goodby Enzyme

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants