[OneChat] Simple Chat UI by zacharyparikh · Pull Request #222816 · elastic/kibana

zacharyparikh · 2025-06-05T13:28:46Z

Summary

Simple.Chat.UI.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

…ge chunks

pgayvallet · 2025-06-25T16:07:18Z

/ci

…urce-definitions/scripts/fix-location-collection.ts'

pgayvallet

LGTM 👍

pgayvallet · 2025-06-25T19:04:54Z

x-pack/platform/plugins/shared/onechat/public/application/hooks/use_conversation.ts

+  const setConversation = (updater: (conversation?: Conversation) => Conversation) => {
+    queryClient.setQueryData<Conversation>(queryKey, updater);
+  };
+  const setCurrentRound = (updater: (conversationRound: ConversationRound) => void) => {
+    setConversation(
+      produce((draft) => {
+        const round = draft?.rounds?.at(-1);
+        if (round) {
+          updater(round);
+        }


Wasn't expecting that kind of approach, but I believe it makes sense in the react-query way.

elasticmachine · 2025-06-25T20:26:53Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: fed1912

Failed CI Steps

FTR Configs #37

Test Failures

[job] [logs] FTR Configs #37 / InfraOps App Metrics UI Node Details #Asset Type: host without metrics Overview Tab "before all" hook for "cpuUsage tile should be shown"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`onechat`	33	103	+70

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`onechat`	0.0B	30.4KB	+30.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`onechat`	6.7KB	10.3KB	+3.7KB
`serverlessSearch`	26.5KB	26.6KB	+22.0B
total			+3.7KB

Unknown metric groups

async chunk count

id	before	after	diff
`onechat`	0	1	+1

miscellaneous assets size

id	before	after	diff
`onechat`	0.0B	152.3KB	+152.3KB

History

💔 Build #312751 failed 1a7a368
💔 Build #312637 failed 1a7a368
💔 Build #312404 failed 37f117b
💔 Build #312109 failed 2b80594
💔 Build #312059 failed b0115e4
💔 Build #311721 failed ae6c28b

joemcelroy · 2025-06-27T09:44:59Z

x-pack/platform/plugins/shared/onechat/README.md

+To enable the Chat UI located at `/app/chat/`, add the following to your Kibana config:
+
+```yaml
+uiSettings.overrides:


thanks for starting this!

No problem, it was Oren's suggestion

joemcelroy · 2025-06-27T10:09:40Z

...platform/plugins/shared/onechat/public/application/components/conversations/conversation.tsx

+
+const conversationPanelClass = css`
+  min-height: 100%;
+  max-width: 850px;


we try not to hardcode widths here. You should be able to reach the euiTheme via hook and get the spacing values.

max-width: calc(${euiTheme.size.xl} * 10);

Styling will likely be changing anyways in follow up

joemcelroy · 2025-06-27T10:14:21Z

...ugins/shared/onechat/public/application/components/conversations/conversation_input_form.tsx

+  `;
+
+  const inputFlexItemClass = css`
+    max-width: 900px;


same here with hardcoded width

joemcelroy · 2025-06-27T10:19:19Z

...red/onechat/public/application/components/conversations/conversation_rounds/round_answer.tsx

+                  </div>
+                ) : (
+                  <EuiText size="s" color="subdued">
+                    No result available


missing localisation but we can ignore here as this is going to have changes.

joemcelroy

Looks great! Feel free to merge now without changes and address them in another PR, for the sake of a passing build :)

## Summary Fixing a type error coming from a potential race-merge situation. #222816 + #224801

zacharyparikh force-pushed the onechat/simple-ui branch 4 times, most recently from 3a003af to 07cef87 Compare June 10, 2025 12:58

zacharyparikh force-pushed the onechat/simple-ui branch 3 times, most recently from e62ad4a to ee3b3f8 Compare June 18, 2025 13:05

zacharyparikh and others added 16 commits June 18, 2025 10:57

WIP OneChat UI

48ec5fa

ConversationsService list - return array instead of object

9d80f2c

Adapt Chat Components to Onechat

ab154d2

WIP Add OneChat to Serverless Navigation Tree

4be24c4

Remove unused conversations_panel components

7ae836f

Remove unused chat_conversation_progress components

2bb4f99

[jedr] fix use_kibana hook to include internal services

d0453c9

Fix conversation routing

5936550

Handle conversation events

b1c22d5

Remove duplicate OneChat link in navigation tree

58df7b1

Add new conversation button

6c5016f

WIP Use persisted conversation rounds

f08e338

[jedr] hacky way to show tool calls with result! Please refactor

0515651

Revert demo only changes

0445f30

Modify Onechat Link in Navigation Tree

af28709

Fix warnings

093140b

zacharyparikh force-pushed the onechat/simple-ui branch from ee3b3f8 to 093140b Compare June 18, 2025 14:57

zacharyparikh added 2 commits June 18, 2025 12:03

Optimistically update conversation round for streamed assistant messa…

6c10bf8

…ge chunks

Update query data for new conversation id

3f5ba3e

zacharyparikh force-pushed the onechat/simple-ui branch from a8c2540 to 3f5ba3e Compare June 18, 2025 17:50

zacharyparikh added 3 commits June 20, 2025 10:41

Merge branch 'main' into onechat/simple-ui

384c1ff

Merge remote-tracking branch 'upstream/main' into onechat/simple-ui

7d857a1

Add feature flag to disable OneChat page

8e5bc8b

Fix i18n ids in server/plugin.ts

1a7a368

zacharyparikh and others added 5 commits June 25, 2025 13:54

Register onechat:chat:enabled ui setting

1f2b5ec

Remove "onechat" segment from public URL path

8fb41d1

Merge remote-tracking branch 'upstream/main' into onechat/simple-ui

d4c6b88

Align plugin setup with elastic#224330

d144a5a

[CI] Auto-commit changed files from 'ts-node .buildkite/pipeline-reso…

fed1912

…urce-definitions/scripts/fix-location-collection.ts'

pgayvallet approved these changes Jun 25, 2025

View reviewed changes

zacharyparikh added 4 commits June 26, 2025 10:45

Merge remote-tracking branch 'upstream/main' into onechat/simple-ui

4a4ab48

Remove initial message context

60213aa

organize imports mount.tsx

3b09815

Remove unused onechat:chat:enabled feature flag

0aa5890

zacharyparikh force-pushed the onechat/simple-ui branch 2 times, most recently from 69d2d10 to 71f1681 Compare June 26, 2025 16:29

Use "conversations" naming rather than "chat"

a5d6af1

zacharyparikh force-pushed the onechat/simple-ui branch from 71f1681 to a5d6af1 Compare June 26, 2025 16:37

gsoldevila removed request for a team June 27, 2025 07:13

joemcelroy reviewed Jun 27, 2025

View reviewed changes

joemcelroy approved these changes Jun 27, 2025

View reviewed changes

zacharyparikh merged commit 3ef270c into elastic:main Jun 27, 2025
10 checks passed

kibanamachine added the v9.2.0 label Jun 27, 2025

delanni mentioned this pull request Jun 27, 2025

fix type error - narrow type after find #225647

Merged

delanni added a commit that referenced this pull request Jun 27, 2025

fix type error - narrow type after find (#225647)

785f749

## Summary Fixing a type error coming from a potential race-merge situation. #222816 + #224801

kibanamachine mentioned this pull request Jul 9, 2025

[ska] relocate deployment-agnostic platform tests #223534

Merged

kibanamachine mentioned this pull request Jul 16, 2025

[ska] relocate observability functional and api_integration tests #227754

Merged

Comments

Conversation

zacharyparikh commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Identify risks

Uh oh!

pgayvallet commented Jun 25, 2025

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 25, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

miscellaneous assets size

History

Uh oh!

joemcelroy Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

zacharyparikh Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

joemcelroy Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zacharyparikh Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

joemcelroy Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

joemcelroy Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joemcelroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zacharyparikh commented Jun 5, 2025 •

edited

Loading

joemcelroy Jun 27, 2025 •

edited

Loading

joemcelroy Jun 27, 2025 •

edited

Loading