[6.4] Updates * characters to an escaped * (#22269)#22271
Closed
jasonrhodes wants to merge 1 commit intoelastic:6.4from
Closed
[6.4] Updates * characters to an escaped * (#22269)#22271jasonrhodes wants to merge 1 commit intoelastic:6.4from
jasonrhodes wants to merge 1 commit intoelastic:6.4from
Conversation
GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
sorenlouv
approved these changes
Aug 22, 2018
Member
sorenlouv
left a comment
sorenlouv
left a comment
There was a problem hiding this comment.
LGTM
Btw. backports normally don't need to be reviewed if they are very similar/identical to the original PR.
Contributor
💚 Build Succeeded |
Member
Author
|
@sqren gotcha re: backport reviews Closing this since we know this doesn't actually fix the issue now, will wait for real fix (which is to just use literal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.4: