Skip to content

[6.x] Updates * characters to an escaped * (#22269)#22270

Closed
jasonrhodes wants to merge 1 commit intoelastic:6.xfrom
jasonrhodes:backport/6.x/pr-22269
Closed

[6.x] Updates * characters to an escaped * (#22269)#22270
jasonrhodes wants to merge 1 commit intoelastic:6.xfrom
jasonrhodes:backport/6.x/pr-22269

Conversation

@jasonrhodes
Copy link
Member

Backports the following commits to 6.x:

GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.
@jasonrhodes jasonrhodes added the backport This PR is a backport of another PR label Aug 22, 2018
@jasonrhodes jasonrhodes requested a review from sorenlouv August 22, 2018 20:08
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes
Copy link
Member Author

Closing this since we know this doesn't actually fix the issue now, will wait for real fix (which is to just use literal * despite GitHub formatting those as bold, our asciidoc parse/compiler renders them as asterisks)

@jasonrhodes jasonrhodes deleted the backport/6.x/pr-22269 branch August 28, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants