Skip to content

[8.19] [AI4DSOC] fix styling to address cutoff when screen is narrow (#219306) #222604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgeller merged 1 commit into from
Jun 4, 2025
Merged

[8.19] [AI4DSOC] fix styling to address cutoff when screen is narrow (#219306) #222604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ns/shared/fleet/public/applications/integrations/sections/epm/components/package_card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export function PackageCard({
titleLineClamp,
descriptionLineClamp,
maxCardHeight,
minCardHeight,
showDescription = true,
showReleaseBadge = true,
}: PackageCardProps) {
Expand Down Expand Up @@ -227,6 +228,8 @@ export function PackageCard({
[class*='euiCard__titleButton'] {
${getLineClampStyles(titleLineClamp)}
}

min-height: ${minCardHeight ? `${minCardHeight}px` : '127px'};
`}
data-test-subj={testid}
isquickstart={isQuickstart}
Expand Down
1 change: 1 addition & 0 deletions ...ns/shared/fleet/public/applications/integrations/sections/epm/screens/home/card_utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export interface IntegrationCardItem {
isUnverified?: boolean;
isUpdateAvailable?: boolean;
maxCardHeight?: number;
minCardHeight?: number;
name: string;
onCardClick?: () => void;
release?: IntegrationCardReleaseLabel;
Expand Down
4 changes: 2 additions & 2 deletions ...blic/common/lib/search_ai_lake/hooks/integrations/use_enhanced_integration_cards.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ describe('applyCategoryBadgeAndStyling', () => {
expect(result.showReleaseBadge).toBe(false);
});

it('should set maxCardHeight to 88', () => {
it('should set minCardHeight to 88', () => {
const result = applyCategoryBadgeAndStyling(mockInt, IntegrationsFacets.available);

expect(result.maxCardHeight).toBe(88);
expect(result.minCardHeight).toBe(88);
});
});

Expand Down
4 changes: 2 additions & 2 deletions ...on/public/common/lib/search_ai_lake/hooks/integrations/use_enhanced_integration_cards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const FEATURED_INTEGRATION_SORT_ORDER = [
'epr:sentinel_one',
'epr:crowdstrike',
];
const INTEGRATION_CARD_MAX_HEIGHT_PX = 88;
const INTEGRATION_CARD_MIN_HEIGHT_PX = 88;

const addPathParamToUrl = (url: string, path: string) => {
const encodedPath = encodeURIComponent(path);
Expand Down Expand Up @@ -67,7 +67,7 @@ export const applyCategoryBadgeAndStyling = (
</EuiFlexItem>,
] as React.ReactNode[])
: [],
maxCardHeight: INTEGRATION_CARD_MAX_HEIGHT_PX,
minCardHeight: INTEGRATION_CARD_MIN_HEIGHT_PX,
};
};

Expand Down
Loading