[AI4DSOC] Fix cases capability used in Security navbar#222504
[AI4DSOC] Fix cases capability used in Security navbar#222504tomsonpl merged 4 commits intoelastic:mainfrom
Conversation
|
/ci |
| if (!hasAccessToSecuritySolution(capabilities)) { | ||
| if ( | ||
| !hasAccessToSecuritySolution(capabilities) && | ||
| !capabilities.securitySolutionCasesV3?.read_cases |
There was a problem hiding this comment.
Had to revert this change, because of an edge case where redirect to cases takes place:
There was a problem hiding this comment.
Caught by this test:
|
/ci |
| return Boolean( | ||
| // Using `siemV2` | ||
| capabilities[SECURITY_FEATURE_ID]?.show || | ||
| capabilities.securitySolutionCasesV2?.read_cases || |
There was a problem hiding this comment.
Can't we just change securitySolutionCasesV2 by securitySolutionCasesV3, instead of doing the cases check outside?
There was a problem hiding this comment.
We can't without changing the behavior. The redirect would get into the /get_started page instead of /cases here:
There was a problem hiding this comment.
@tomsonpl Oh, good point.
Then would you mind creating different functions, with a clear naming, because this is a bit confusing right now. We could have:
- hasSecurityAccess ->
security || attack-discovery(used in app_routes) - hasCasesAccess ->
cases(used in app_routes) - isSecuritySolutionAccessible ->
hasSecurityAccess() || hasCasesAccess()(used in the plugin.tsx)
And consider using CASES_FEATURE_ID instead of hardcoding the version.
Question: Should we consider letting users access Security if they only have the assistant feature? Maybe it should be part of hasSecurityAccess.
There was a problem hiding this comment.
Thanks, changed it as you suggested 👍 I'll get this assistant question back to the team
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15488622283 |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @tomsonpl |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
21 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Fix the issue where Security Section was not displayed.
Closes: #221573