[8.18] Upgrade prismjs 1.29.0 → 1.30.0 (#222019)#222418
Merged
jeramysoucy merged 3 commits intoelastic:8.18from Jun 4, 2025
Merged
[8.18] Upgrade prismjs 1.29.0 → 1.30.0 (#222019)#222418jeramysoucy merged 3 commits intoelastic:8.18from
jeramysoucy merged 3 commits intoelastic:8.18from
Conversation
## Summary Upgrades the `prismjs` dependency to version 1.30.0 where possible. (cherry picked from commit 6968240) # Conflicts: # yarn.lock
SiddharthMantri
approved these changes
Jun 4, 2025
Contributor
SiddharthMantri
left a comment
SiddharthMantri
left a comment
There was a problem hiding this comment.
One non-blocking question. Looks good otherwise
| integrity sha512-DEvV2ZF2r2/63V+tK8hQvrR2ZGn10srHbXviTlcv7Kpzw8jWiNTqbVgjO3IY8RxrrOUF8VPMQQFysYYYv0YZxw== | ||
|
|
||
| prismjs@~1.27.0: | ||
| version "1.27.0" |
Contributor
There was a problem hiding this comment.
Question: I wonder why the next line for the registry is yarnpkg here vs npmjs in the root PR: https://github.com/elastic/kibana/pull/222019/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deR26402
Doesn't seem like an issue but just wanted to highlight
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation