[8.19] [Lens] Keep suggestions up to date with the main workspace (#221901)#222380
Merged
dej611 merged 1 commit intoelastic:8.19from Jun 3, 2025
Merged
[8.19] [Lens] Keep suggestions up to date with the main workspace (#221901)#222380dej611 merged 1 commit intoelastic:8.19from
dej611 merged 1 commit intoelastic:8.19from
Conversation
…21901) ## Summary Fixes elastic#178571 This PR reverts elastic#221248 adding the missing part on it to make the bug found in elastic#178571 disappear. In fact there was just a single line missing who was meant to keep the suggestion frame version up to date with the latest workspace state.  I've tried to add a unit test but it was so hard to actually follow the code underneath, so I settled to add a FTR, which led to few more extras: * subtype selector now has test ids * Lens page now has few more utility helpers for layer cloning and sub type selector ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 0bcd7ff) # Conflicts: # x-pack/test/functional/page_objects/lens_page.ts
1 task
nickofthyme
approved these changes
Jun 3, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation