Skip to content

[8.19] [TSVB/SCSS] Migrate _markdown.scss file (#221297) #222353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariairiartef merged 1 commit into from
Jun 3, 2025
Merged

[8.19] [TSVB/SCSS] Migrate _markdown.scss file (#221297) #222353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions ...vate/vis_types/timeseries/public/application/components/vis_types/markdown/_markdown.scss
View file
Open in desktop

This file was deleted.

47 changes: 41 additions & 6 deletions ...gins/private/vis_types/timeseries/public/application/components/vis_types/markdown/vis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,44 @@ import PropTypes from 'prop-types';
import React from 'react';
import classNames from 'classnames';
import { get } from 'lodash';
import { ClassNames } from '@emotion/react';
import { ClassNames, css } from '@emotion/react';
import { Markdown } from '@kbn/kibana-react-plugin/public';

import { ErrorComponent } from '../../error';
import { replaceVars } from '../../lib/replace_vars';
import { convertSeriesToVars } from '../../lib/convert_series_to_vars';
import { isBackgroundInverted } from '../../../lib/set_is_reversed';

import './_markdown.scss';
const markdownStyles = css`
display: flex;
flex-direction: column;
flex: 1 0 auto;
position: relative;
`;

const markdownContentStyles = css`
display: flex;
flex-direction: column;
flex: 1 0 auto;
position: absolute;
top: 0;
left: 0;
right: 0;
bottom: 0;
overflow: hidden;

&.tvbMarkdown__content--middle {
justify-content: center;
}

&.tvbMarkdown__content--bottom {
justify-content: flex-end;
}

&.tvbMarkdown__content-isScrolling {
overflow: auto;
}
`;

function MarkdownVisualization(props) {
const {
Expand Down Expand Up @@ -54,6 +83,7 @@ function MarkdownVisualization(props) {
});

const contentClasses = classNames(
'eui-scrollBar',
'tvbMarkdown__content',
`tvbMarkdown__content--${model.markdown_vertical_align}`,
{ 'tvbMarkdown__content-isScrolling': model.markdown_scrollbars },
Expand All @@ -63,17 +93,22 @@ function MarkdownVisualization(props) {
const markdownError = markdownSource instanceof Error ? markdownSource : null;

markdown = (
<div className="tvbMarkdown" data-test-subj="tsvbMarkdown">
<div className="tvbMarkdown" css={markdownStyles} data-test-subj="tsvbMarkdown">
{markdownError && <ErrorComponent error={markdownError} />}
<ClassNames>
{({ css, cx }) => (
<div
className={cx(
contentClasses,
// wrapping select for markdown body to make sure selector specificity wins over base styles
css(`.kbnMarkdown__body {
${model.markdown_css}
}`)
css(
[
`.kbnMarkdown__body {
${model.markdown_css}
}`,
],
markdownContentStyles
)
)}
>
<div>
Expand Down