Skip to content

[8.19] [TSVB/SCSS] Migrate _annotations_editor.scss file (#220900) #222349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariairiartef merged 1 commit into from
Jun 3, 2025
Merged

[8.19] [TSVB/SCSS] Migrate _annotations_editor.scss file (#220900) #222349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...ugins/private/vis_types/timeseries/public/application/components/_annotations_editor.scss
View file
Open in desktop

This file was deleted.

15 changes: 14 additions & 1 deletion ...orm/plugins/private/vis_types/timeseries/public/application/components/annotation_row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { FormattedMessage } from '@kbn/i18n-react';

import type { Query } from '@kbn/es-query';
import { KBN_FIELD_TYPES } from '@kbn/data-plugin/public';
import { css } from '@emotion/react';
import { getDataViewsStart } from '../../services';

import { AddDeleteButtons } from './add_delete_buttons';
Expand All @@ -49,6 +50,17 @@ const RESTRICT_FIELDS = [KBN_FIELD_TYPES.DATE];
const INDEX_PATTERN_KEY = 'index_pattern';
const TIME_FIELD_KEY = 'time_field';

const useEditorStyles = () => {
const { euiTheme } = useEuiTheme();
const styles = useMemo(() => {
return css({
marginBottom: euiTheme.size.base,
padding: euiTheme.size.s,
});
}, [euiTheme]);
return styles;
};

export interface AnnotationRowProps {
annotation: Annotation;
fields: VisFields;
Expand Down Expand Up @@ -77,6 +89,7 @@ export const AnnotationRow = ({
const [fetchedIndex, setFetchedIndex] = useState<IndexPatternSelectProps['fetchedIndex']>(null);

const { euiTheme } = useEuiTheme();
const editorStyles = useEditorStyles();

useEffect(() => {
const updateFetchedIndex = async (index: IndexPatternValue) => {
Expand Down Expand Up @@ -133,7 +146,7 @@ export const AnnotationRow = ({
);

return (
<div className="tvbAnnotationsEditor" key={model.id}>
<div className="tvbAnnotationsEditor" key={model.id} css={editorStyles}>
<EuiFlexGroup responsive={false}>
<EuiFlexItem grow={false}>
<ColorPicker disableTrash={true} onChange={onChange} name="color" value={model.color} />
Expand Down
20 changes: 16 additions & 4 deletions ...plugins/private/vis_types/timeseries/public/application/components/annotations_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,29 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import React, { useCallback } from 'react';
import React, { useCallback, useMemo } from 'react';
import { v4 as uuidv4 } from 'uuid';
import { EuiSpacer, EuiTitle, EuiButton, EuiText } from '@elastic/eui';
import { EuiSpacer, EuiTitle, EuiButton, EuiText, useEuiTheme } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import type { DataView } from '@kbn/data-views-plugin/public';

import { css } from '@emotion/react';
import { AnnotationRow } from './annotation_row';
import { collectionActions, CollectionActionsProps } from './lib/collection_actions';

import type { Panel, Annotation } from '../../../common/types';
import type { VisFields } from '../lib/fetch_fields';

import './_annotations_editor.scss';
const useContainerStyles = () => {
const { euiTheme } = useEuiTheme();
const styles = useMemo(() => {
return css({
padding: euiTheme.size.base,
backgroundColor: euiTheme.colors.lightestShade,
});
}, [euiTheme]);
return styles;
};

interface AnnotationsEditorProps {
fields: VisFields;
Expand Down Expand Up @@ -65,6 +75,8 @@ const getCollectionActionsProps = (props: AnnotationsEditorProps) =>
export const AnnotationsEditor = (props: AnnotationsEditorProps) => {
const { annotations } = props.model;

const containerStyles = useContainerStyles();

const handleAdd = useCallback(
() =>
collectionActions.handleAdd(
Expand Down Expand Up @@ -92,7 +104,7 @@ export const AnnotationsEditor = (props: AnnotationsEditorProps) => {
);

return (
<div className="tvbAnnotationsEditor__container">
<div className="tvbAnnotationsEditor__container" css={containerStyles}>
{annotations?.length ? (
<div>
<EuiTitle size="s">
Expand Down