Skip to content

[8.19] Default EUI_AMSTERDAM to true when unset #222286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkajtoch merged 1 commit into from
Jun 3, 2025
+10 −2
Merged

[8.19] Default EUI_AMSTERDAM to true when unset #222286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion kbn_pm/src/commands/bootstrap/bootstrap_command.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ export const command = {
const validate = args.getBooleanValue('validate') ?? true;
const quiet = args.getBooleanValue('quiet') ?? false;
const reactVersion = process.env.REACT_18 ? '18' : '17';
const euiAmsterdam = process.env.EUI_AMSTERDAM === 'true';

// Default to true when EUI_AMSTERDAM is not set on 8.19
// TODO: Remove when Kibana 8.19 is EOL and Amsterdam backports aren't needed anymore
// https://github.com/elastic/kibana/issues/221593
const euiAmsterdam = !process.env.EUI_AMSTERDAM || process.env.EUI_AMSTERDAM === 'true';

const vscodeConfig =
args.getBooleanValue('vscode') ?? (process.env.KBN_BOOTSTRAP_NO_VSCODE ? false : true);

Expand Down
5 changes: 4 additions & 1 deletion kbn_pm/src/commands/watch_command.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export const command = {
await Bazel.watch(log, {
offline: args.getBooleanValue('offline') ?? true,
reactVersion: process.env.REACT_18 ? '18' : '17',
euiAmsterdam: process.env.EUI_AMSTERDAM === 'true',
// Default to true when EUI_AMSTERDAM is not set on 8.19
// TODO: Remove when Kibana 8.19 is EOL and Amsterdam backports aren't needed anymore
// https://github.com/elastic/kibana/issues/221593
euiAmsterdam: !process.env.EUI_AMSTERDAM || process.env.EUI_AMSTERDAM === 'true',
});
},
};