[Security Solution] Fix MKI tests for prebuilt rules#222170
[Security Solution] Fix MKI tests for prebuilt rules#222170maximpn merged 1 commit intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
a0d066b to
1b4297e
Compare
1b4297e to
a4aad7a
Compare
jkelas
left a comment
There was a problem hiding this comment.
The code looks good to me. After syncing with the author who led me through the code and explained me why it failed before, and what changed now, and after seeing the pipeline working fine now, when run manually, I am approving.
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15394652428 |
**Relates to:** elastic#219831 ## Summary This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in elastic#219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. ## Pipelines [Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR. - ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) - ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) (cherry picked from commit d853886)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#222221) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Fix MKI tests for prebuilt rules (#222170)](#222170) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-02T14:16:42Z","message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix MKI tests for prebuilt rules","number":222170,"url":"https://github.com/elastic/kibana/pull/222170","mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222170","number":222170,"mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
**Relates to:** elastic#219831 ## Summary This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in elastic#219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. ## Pipelines [Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR. - ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) - ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)
**Relates to:** elastic#219831 ## Summary This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in elastic#219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. ## Pipelines [Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR. - ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) - ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)
**Relates to:** elastic#219831 ## Summary This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in elastic#219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. ## Pipelines [Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR. - ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) - ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) (cherry picked from commit d853886)
**Relates to:** elastic#219831 ## Summary This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in elastic#219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. ## Pipelines [Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR. - ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) - ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786) (cherry picked from commit d853886)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…226501) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Fix MKI tests for prebuilt rules (#222170)](#222170) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-02T14:16:42Z","message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix MKI tests for prebuilt rules","number":222170,"url":"https://github.com/elastic/kibana/pull/222170","mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222170","number":222170,"mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/222221","number":222221,"state":"MERGED","mergeCommit":{"sha":"ed7df7c000f37c15f137eb99df42d9ccbc76a515","message":"[8.19] [Security Solution] Fix MKI tests for prebuilt rules (#222170) (#222221)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Fix MKI tests for prebuilt rules\n(#222170)](https://github.com/elastic/kibana/pull/222170)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
|
Starting backport for target branches: 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16069789395 |
…#226502) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix MKI tests for prebuilt rules (#222170)](#222170) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2025-06-02T14:16:42Z","message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix MKI tests for prebuilt rules","number":222170,"url":"https://github.com/elastic/kibana/pull/222170","mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222170","number":222170,"mergeCommit":{"message":"[Security Solution] Fix MKI tests for prebuilt rules (#222170)\n\n**Relates to:** https://github.com/elastic/kibana/pull/219831\n\n## Summary\n\nThis PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in `x-pack/test/security_solution_api_integration/package.json` are used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests. \n\n## Pipelines\n\n[Kibana / Serverless / Security Solution Quality Gate / Rule Management](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management) pipeline was manually ran against this PR.\n\n- ✅ [Periodic pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)\n- ✅ [Quality gate pipeline](https://buildkite.com/elastic/kibana-serverless-security-solution-quality-gate-rule-management/builds/2786)","sha":"d8538862505c7a7d2f4d6024e479b5ea88b5ddbd"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/222221","number":222221,"state":"MERGED","mergeCommit":{"sha":"ed7df7c000f37c15f137eb99df42d9ccbc76a515","message":"[8.19] [Security Solution] Fix MKI tests for prebuilt rules (#222170) (#222221)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Security Solution] Fix MKI tests for prebuilt rules\n(#222170)](https://github.com/elastic/kibana/pull/222170)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Maxim Palenov <maxim.palenov@elastic.co>"}}]}] BACKPORT-->
|
Starting backport for target branches: 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16069795516 |
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16069801640 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Relates to: #219831
Summary
This PR fixes MKI tests configuration for prebuilt rules after performing refactoring in #219831. Since shorthand script in
x-pack/test/security_solution_api_integration/package.jsonare used only for running MKI tests and local development it didn't cause PR pipeline failures and became prominent after running MKI tests.Pipelines
Kibana / Serverless / Security Solution Quality Gate / Rule Management pipeline was manually ran against this PR.