feat(slo): add metadata in rollup document#222108
Merged
kdelemme merged 6 commits intoelastic:mainfrom Jun 10, 2025
Merged
Conversation
github-actions
bot
added
the
author:obs-ux-management
kdelemme
added
release_note:skip
kdelemme
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
changed the title
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @kdelemme |
baileycash-elastic
approved these changes
Jun 9, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15562270843 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
pmuellr
pushed a commit
to pmuellr/kibana
that referenced
this pull request
Jun 11, 2025
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jun 12, 2025
(cherry picked from commit 33842c2) # Conflicts: # x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Jun 12, 2025
(cherry picked from commit 33842c2) # Conflicts: # x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
kdelemme
added a commit
that referenced
this pull request
Jun 13, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [feat(slo): add metadata in rollup document (#222108)](#222108) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-10T14:27:29Z","message":"feat(slo): add metadata in rollup document (#222108)","sha":"33842c2c2be54c1fe5c26655bd3e1750154ce045","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"feat(slo): add metadata in rollup document","number":222108,"url":"https://github.com/elastic/kibana/pull/222108","mergeCommit":{"message":"feat(slo): add metadata in rollup document (#222108)","sha":"33842c2c2be54c1fe5c26655bd3e1750154ce045"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222108","number":222108,"mergeCommit":{"message":"feat(slo): add metadata in rollup document (#222108)","sha":"33842c2c2be54c1fe5c26655bd3e1750154ce045"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves https://github.com/elastic/enhancements/issues/23634
Resolves #218987
This PR adds
slo.nameandslo.tagsinto the sli rollup data. We had to bump the internal version from 3.4 to 3.5 in order to support the new mappings.Existing SLOs will continue to work and write into the v3.4 indices until they are either reseted or updated.
New SLOs will write into the new v3.5 indices.
Reason for bumping the index version
If we do not add the new fields as part of the component template mappings for the SLI rollup index, ES will deduce the mapping but will use some text and nested keyword type.
Because this is a component template, the mapping is only applied at index creation, and the SLI rollup index is created only for a new version or monthly when the ingest pipeline creates a new monthly rolling index.