Skip to content

Update Risk severity color map to EUI Borealis #222061

Merged
albertoblaz merged 2 commits intoelastic:mainfrom
albertoblaz:asset-inv-risk-colors
Jun 4, 2025
Merged

Update Risk severity color map to EUI Borealis #222061
albertoblaz merged 2 commits intoelastic:mainfrom
albertoblaz:asset-inv-risk-colors

Conversation

@albertoblaz
Copy link
Copy Markdown
Contributor

@albertoblaz albertoblaz commented May 30, 2025

Summary

Solves this issue in relation to Risk severity in the context of Security solution:

Map risk severity color map to the new color tokens in EUI Borealis (see new pattern).

These new color tokens were introduced through this PR:

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

This is a low-risk change that only presents different colors where risk severity is used.

@albertoblaz albertoblaz self-assigned this May 30, 2025
@albertoblaz albertoblaz force-pushed the asset-inv-risk-colors branch from 8a0b595 to 4adcad3 Compare June 3, 2025 13:07
@albertoblaz albertoblaz requested a review from a team June 3, 2025 13:08
@albertoblaz albertoblaz marked this pull request as ready for review June 3, 2025 13:08
@albertoblaz albertoblaz requested a review from a team as a code owner June 3, 2025 13:08
@albertoblaz albertoblaz requested a review from machadoum June 3, 2025 13:08
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Copy link
Copy Markdown
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for this!

Copy link
Copy Markdown
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanrathier
Copy link
Copy Markdown
Contributor

You need to update the branch to remove the Serverless and OAS changes the CI committed.

@albertoblaz albertoblaz force-pushed the asset-inv-risk-colors branch from baa08f0 to 6bb5f17 Compare June 4, 2025 13:57
@albertoblaz albertoblaz enabled auto-merge (squash) June 4, 2025 13:58
@albertoblaz albertoblaz merged commit e422251 into elastic:main Jun 4, 2025
10 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/15447233908

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.3MB 9.3MB -116.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 93.2KB 93.2KB -1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 607 609 +2

Total ESLint disabled count

id before after diff
securitySolution 701 703 +2

History

cc @albertoblaz

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222061

Questions ?

Please refer to the Backport tool documentation

@albertoblaz albertoblaz deleted the asset-inv-risk-colors branch June 5, 2025 07:57
@albertoblaz
Copy link
Copy Markdown
Contributor Author

I've decided not to backport to v9.0 since these new color palette does not 100% map with existing color tokens in 9.0

@albertoblaz albertoblaz added backport:skip This PR does not require backporting and removed backport:prev-minor labels Jun 5, 2025
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
## Summary

Solves this issue in relation to Risk severity in the context of
Security solution:
- elastic/security-team#11516

Map risk severity color map to the new color tokens in EUI Borealis
([see new
pattern](https://eui.elastic.co/docs/patterns/severity/index.html)).

These new color tokens were introduced through this PR:
- elastic/eui#8601

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

This is a low-risk change that only presents different colors where risk
severity is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:enhancement Team:Cloud Security Cloud Security team related v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants