[Dashboard as code] Embeddable API Integration#221975
Closed
ThomThomson wants to merge 60 commits intomainfrom
Closed
[Dashboard as code] Embeddable API Integration#221975ThomThomson wants to merge 60 commits intomainfrom
ThomThomson wants to merge 60 commits intomainfrom
Conversation
…221692) Note: _This PR does not need to be reviewed by external teams. This PR merges into a feature branch that Kibana presentation team is working on to support embeddable integrations with Dashboards as Code._
…act reference handling to server
ThomThomson
changed the title
…anagement (#221981) Note: _This PR does not need to be reviewed by external teams. This PR merges into a feature branch that Kibana presentation team is working on to support embeddable integrations with Dashboards as Code._
Adds a `startServices` method for the dashboard server to provide the embeddable service that can be used in the migration to correctly extract references. This also logs a warning instead of throwing if the migration fails. Here is an example dashboard saved object that triggers the migration on import. [7.8.0-dashboard.ndjson.zip](https://github.com/user-attachments/files/20521831/7.8.0-dashboard.ndjson.zip) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Project deployments require a Github label, please add one or more of |
…om/elastic/kibana into dashboardApi/embeddableIntegration
ThomThomson
changed the title
ThomThomson
changed the title
…ntManagementRegistry async (#223050) Note: _This PR does not need to be reviewed by external teams. This PR merges into a feature branch that Kibana presentation team is working on to support embeddable integrations with Dashboards as Code._ Makes the `EmbeddableContentManagementRegistry` an async registry to reduce bundle size.
…ableIntegration # Conflicts: # src/platform/plugins/shared/dashboard/server/dashboard_saved_object/migrations/dashboard_saved_object_migrations.test.ts
…om/elastic/kibana into dashboardApi/embeddableIntegration
Contributor
|
@elasticmachine merge upstream |
nreese
added
backport:skip
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
|
Sorry for the pings, accidentally clicked "Ready for review". PR is not ready for review and is still in draft. Please "unsubscribe" to avoid getting updates for this PR. |
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Closing, replacing with #227141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192622
Closes #222472
Closes #222466