[ES|QL] suggest pipe after single column in EVAL#221851
Merged
drewdaemon merged 33 commits intoelastic:mainfrom May 30, 2025
Merged
[ES|QL] suggest pipe after single column in EVAL#221851drewdaemon merged 33 commits intoelastic:mainfrom
drewdaemon merged 33 commits intoelastic:mainfrom
Conversation
drewdaemon
added
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15350501249 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 30, 2025
## Summary Previously, we weren't considering an assignment with a single field name to be a "complete" expression in `EVAL`. This changes that because it seems like people are using `EVAL` for this, even though we also have a `RENAME` command. https://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac (cherry picked from commit 8659427)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
May 30, 2025
…22087) # Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] suggest pipe after single column in EVAL (#221851)](#221851) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-05-30T15:46:33Z","message":"[ES|QL] suggest pipe after single column in EVAL (#221851)\n\n## Summary\n\nPreviously, we weren't considering an assignment with a single field\nname to be a \"complete\" expression in `EVAL`. This changes that because\nit seems like people are using `EVAL` for this, even though we also have\na `RENAME` command.\n\n\n\nhttps://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac","sha":"865942742ae00b0d1146f596f11dcb2e54bdb1dc","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] suggest pipe after single column in EVAL","number":221851,"url":"https://github.com/elastic/kibana/pull/221851","mergeCommit":{"message":"[ES|QL] suggest pipe after single column in EVAL (#221851)\n\n## Summary\n\nPreviously, we weren't considering an assignment with a single field\nname to be a \"complete\" expression in `EVAL`. This changes that because\nit seems like people are using `EVAL` for this, even though we also have\na `RENAME` command.\n\n\n\nhttps://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac","sha":"865942742ae00b0d1146f596f11dcb2e54bdb1dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221851","number":221851,"mergeCommit":{"message":"[ES|QL] suggest pipe after single column in EVAL (#221851)\n\n## Summary\n\nPreviously, we weren't considering an assignment with a single field\nname to be a \"complete\" expression in `EVAL`. This changes that because\nit seems like people are using `EVAL` for this, even though we also have\na `RENAME` command.\n\n\n\nhttps://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac","sha":"865942742ae00b0d1146f596f11dcb2e54bdb1dc"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary Previously, we weren't considering an assignment with a single field name to be a "complete" expression in `EVAL`. This changes that because it seems like people are using `EVAL` for this, even though we also have a `RENAME` command. https://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary Previously, we weren't considering an assignment with a single field name to be a "complete" expression in `EVAL`. This changes that because it seems like people are using `EVAL` for this, even though we also have a `RENAME` command. https://github.com/user-attachments/assets/eab58527-ebfa-45bc-abb1-63b996ebbeac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we weren't considering an assignment with a single field name to be a "complete" expression in
EVAL. This changes that because it seems like people are usingEVALfor this, even though we also have aRENAMEcommand.Screen.Recording.2025-05-28.at.2.28.25.PM.mov