[8.19] [Fleet][Security & Observability Onboarding] Generalize and consolidate custom fleet onboarding logic (#215561)#221819
Merged
angorayc merged 1 commit intoelastic:8.19from May 28, 2025
Conversation
…te custom fleet onboarding logic (elastic#215561) ## Summary Updated fleet custom navigation logic to be more generic and consistent between security and observability onboarding flows. ## Details When attempting to start using the custom logic for routing back to onboarding pages for another project, I noticed inconsistencies in how we were linking back to the onboarding pages for the `Back to selection` button on the Integrations overview page and the `Cancel` and `Save and continue` on the Add integration page. Due to these inconsistencies, both custom routing mechanisms couldn't both work at the same time. I re-worked the implementation of the back button to match the cancel/save buttons and utilize `navigateToApp` to fix. Now instead of observability utilizing the `observabilityOnboardingLink` query param, and security utilizing both `observabilityOnboardingLink` and `onboardingAppId`, both solutions will use `returnAppId` and `returnPath` (or different names if we don't love these) to route back to their sourcing locations. Note: Observability onboarding will also now inherit logic the security onboarding team added where the same query parameters route back to the source when a user cancels or saves from the Add integration page (item 3 from [this PR](elastic#194028)) ## Screen recordings Regular integrations page https://github.com/user-attachments/assets/0f306bec-657f-4a7a-b2da-25557899b629 Security onboarding https://github.com/user-attachments/assets/d2a161a0-62ee-40b1-9dd9-5165aea6a65a Observability onboarding https://github.com/user-attachments/assets/89f6b9a3-a348-4488-8688-1d5c96716185 Relates: - elastic#181520 - elastic/security-team#11789 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 6967952)
botelastic
Bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
|
kgeller
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation