[Task Manager] Remove spaces plugin dependency in task manager plugin#221596
Merged
kowalczyk-krzysztof merged 5 commits intoelastic:mainfrom May 28, 2025
Conversation
kowalczyk-krzysztof
added
the
release_note:skip
kowalczyk-krzysztof
added
Feature:Task Manager
backport:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
ymao1
approved these changes
May 27, 2025
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM thanks for the cleanup!
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…elastic#221596) ## Summary This PR removes spaces plugin dependency from task manager plugin and replaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from `@kbn/spaces-utils` package. This prevents a circular dependency from happening in elastic#220138 > [!NOTE] > I'm changing the test case to use `test-space` id instead of `testSpace` as this was an invalid space id and it shouldn't have been used in the mock. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kowalczyk-krzysztof
added
backport:version
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15412990661 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kowalczyk-krzysztof
added a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Jun 3, 2025
…elastic#221596) ## Summary This PR removes spaces plugin dependency from task manager plugin and replaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from `@kbn/spaces-utils` package. This prevents a circular dependency from happening in elastic#220138 > [!NOTE] > I'm changing the test case to use `test-space` id instead of `testSpace` as this was an invalid space id and it shouldn't have been used in the mock. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 017c2e5)
kowalczyk-krzysztof
added a commit
that referenced
this pull request
Jun 3, 2025
… plugin (#221596) (#222355) # Backport This will backport the following commits from `main` to `8.19`: - [[Task Manager] Remove spaces plugin dependency in task manager plugin (#221596)](#221596) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2025-05-28T07:28:16Z","message":"[Task Manager] Remove spaces plugin dependency in task manager plugin (#221596)\n\n## Summary\n\nThis PR removes spaces plugin dependency from task manager plugin and\nreplaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from\n`@kbn/spaces-utils` package. This prevents a circular dependency from\nhappening in https://github.com/elastic/kibana/pull/220138\n\n> [!NOTE] \n> I'm changing the test case to use `test-space` id instead of\n`testSpace` as this was an invalid space id and it shouldn't have been\nused in the mock.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"017c2e53f578d7da08616cca7cd4f9f920b5a571","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","backport:version","v9.1.0","v8.19.0"],"title":"[Task Manager] Remove spaces plugin dependency in task manager plugin","number":221596,"url":"https://github.com/elastic/kibana/pull/221596","mergeCommit":{"message":"[Task Manager] Remove spaces plugin dependency in task manager plugin (#221596)\n\n## Summary\n\nThis PR removes spaces plugin dependency from task manager plugin and\nreplaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from\n`@kbn/spaces-utils` package. This prevents a circular dependency from\nhappening in https://github.com/elastic/kibana/pull/220138\n\n> [!NOTE] \n> I'm changing the test case to use `test-space` id instead of\n`testSpace` as this was an invalid space id and it shouldn't have been\nused in the mock.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"017c2e53f578d7da08616cca7cd4f9f920b5a571"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221596","number":221596,"mergeCommit":{"message":"[Task Manager] Remove spaces plugin dependency in task manager plugin (#221596)\n\n## Summary\n\nThis PR removes spaces plugin dependency from task manager plugin and\nreplaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from\n`@kbn/spaces-utils` package. This prevents a circular dependency from\nhappening in https://github.com/elastic/kibana/pull/220138\n\n> [!NOTE] \n> I'm changing the test case to use `test-space` id instead of\n`testSpace` as this was an invalid space id and it shouldn't have been\nused in the mock.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"017c2e53f578d7da08616cca7cd4f9f920b5a571"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
…elastic#221596) ## Summary This PR removes spaces plugin dependency from task manager plugin and replaces `spacesService.getActiveSpace` with `getSpaceIdFromPath` from `@kbn/spaces-utils` package. This prevents a circular dependency from happening in elastic#220138 > [!NOTE] > I'm changing the test case to use `test-space` id instead of `testSpace` as this was an invalid space id and it shouldn't have been used in the mock. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kowalczyk-krzysztof
deleted the
chore/taskmanager-remove-space-dependency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes spaces plugin dependency from task manager plugin and replaces
spacesService.getActiveSpacewithgetSpaceIdFromPathfrom@kbn/spaces-utilspackage. This prevents a circular dependency from happening in #220138Note
I'm changing the test case to use
test-spaceid instead oftestSpaceas this was an invalid space id and it shouldn't have been used in the mock.