[8.19] [Custom threshold] Save group by information with dynamic mapping (#219826)#221476
Merged
maryam-saeidi merged 3 commits intoelastic:8.19from May 26, 2025
Merged
Conversation
…astic#219826) Relaetd to elastic#183248 Auto-increasing mapping limit PR: elastic#216719 ## Summary In this PR, we are saving dynamically mapped group by information for the custom threshold rule. This consists of two parts: 1. Adding a dynamic field ``` // kibana.alert.grouping [ALERT_GROUPING]: { type: 'object', dynamic: true, array: false, required: false, }, ``` 2. Adding a dynamic template ``` dynamicTemplates: [ { strings_as_keywords: { path_match: 'kibana.alert.grouping.*', match_mapping_type: 'string', mapping: { type: 'keyword', ignore_above: 1024, }, }, }, ], ``` The result of adding these mappings can be seen below: |Alert|Mapping| |---|---| ||| If the number of mapping limit is exceeded, the fields that are not mapped are going to be added to the `_ignored` field, but the value is available in the doc. <img src="https://github.com/user-attachments/assets/b84bcf03-b757-4f37-a93f-2559aefa5bcf" width=500 /> (cherry picked from commit 1ec3296) # Conflicts: # x-pack/solutions/observability/plugins/observability/server/lib/rules/custom_threshold/custom_threshold_executor.ts
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
kdelemme
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation