[ES|QL] support SAMPLE command#221446
Merged
stratoula merged 38 commits intoelastic:mainfrom Jun 2, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
reviewed
May 30, 2025
Contributor
There was a problem hiding this comment.
It looks great. 🙌 About your comment about the autocomplete in the seed, I was thinking of it and I think it makes sense to add some integer suggestions with the pipe here (maybe the ones we have for limit (?))
I see there are other places we suggest optional params such as here and I find it a very nice pattern
or in change_point
But happy to discuss further. I don't have a strong opinion and I don't consider it a blocker. I don't approve mostly for aligning on this.
...m/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/commands/sample/index.ts
Outdated
Show resolved
Hide resolved
...m/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/commands/sample/index.ts
Show resolved
Hide resolved
Contributor
Author
|
@stratoula I agree that making a suggestion for seed could help the user discover it. I'm just not sure whether any values for Perhaps I could provide an explanation in the suggestion itself. I'll look a bit more into this. |
Contributor
Author
|
@stratoula WDYT? Screen.Recording.2025-05-30.at.2.14.53.PM.mov |
stratoula
approved these changes
Jun 2, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Looks great, I didnt test again, LGTM
stratoula
added
release_note:enhancement
release_note:skip
Contributor
|
Release note: skip as the feature is hidden and only available on snaphsot releases. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Page load bundle
|
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/15386080012 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
|
Rerun when this #222023 is backported |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 2, 2025
## Summary Closes elastic#217977 <img width="820" alt="Screenshot 2025-05-28 at 11 38 57 AM" src="https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f" /> ### Open questions - Should we be suggesting anything for `seed`? - ~Do the suggestions for sampling rate make sense?~ (approved) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit 748638d)
This was referenced Jun 2, 2025
stratoula
added a commit
that referenced
this pull request
Jun 3, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] support `SAMPLE` command (#221446)](#221446) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-06-02T07:09:40Z","message":"[ES|QL] support `SAMPLE` command (#221446)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/217977\n\n<img width=\"820\" alt=\"Screenshot 2025-05-28 at 11 38 57 AM\"\nsrc=\"https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f\"\n/>\n\n### Open questions\n- Should we be suggesting anything for `seed`?\n- ~Do the suggestions for sampling rate make sense?~ (approved)\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"748638d4a93c667262badd91ce022ff1d90cbe7b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] support `SAMPLE` command","number":221446,"url":"https://github.com/elastic/kibana/pull/221446","mergeCommit":{"message":"[ES|QL] support `SAMPLE` command (#221446)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/217977\n\n<img width=\"820\" alt=\"Screenshot 2025-05-28 at 11 38 57 AM\"\nsrc=\"https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f\"\n/>\n\n### Open questions\n- Should we be suggesting anything for `seed`?\n- ~Do the suggestions for sampling rate make sense?~ (approved)\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"748638d4a93c667262badd91ce022ff1d90cbe7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221446","number":221446,"mergeCommit":{"message":"[ES|QL] support `SAMPLE` command (#221446)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/217977\n\n<img width=\"820\" alt=\"Screenshot 2025-05-28 at 11 38 57 AM\"\nsrc=\"https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f\"\n/>\n\n### Open questions\n- Should we be suggesting anything for `seed`?\n- ~Do the suggestions for sampling rate make sense?~ (approved)\n\n---------\n\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"748638d4a93c667262badd91ce022ff1d90cbe7b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co>
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary Closes elastic#217977 <img width="820" alt="Screenshot 2025-05-28 at 11 38 57 AM" src="https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f" /> ### Open questions - Should we be suggesting anything for `seed`? - ~Do the suggestions for sampling rate make sense?~ (approved) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary Closes elastic#217977 <img width="820" alt="Screenshot 2025-05-28 at 11 38 57 AM" src="https://github.com/user-attachments/assets/fcee1c7c-3c90-4d1d-9e10-0453a8c3307f" /> ### Open questions - Should we be suggesting anything for `seed`? - ~Do the suggestions for sampling rate make sense?~ (approved) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #217977
Open questions
seed?Do the suggestions for sampling rate make sense?(approved)