[ObsUX] Remove background for dropdown button, visual refresh bug#221366
Conversation
MiriamAparicio
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
| <EuiFlexItem grow={false}> | ||
| <EuiButtonEmpty | ||
| aria-label={i18n.translate('xpack.infra.dropdownButton.button.ariaLabel', { | ||
| defaultMessage: label, |
There was a problem hiding this comment.
Is this intended? The label message does not seem contextual enough in this case.
There was a problem hiding this comment.
You're right, I will add something else to the message, like "Metric options", "Group by options" etc
There was a problem hiding this comment.
Cool thanks!
I realize now that the translation key might not be very specific, so it could apply to any dropdown button within infra. I’m not sure if we have any specific guidelines around translation keys.
Thanks @iblancof for testing, I will recheck it, but the background was fixed against the EUI PR, to not show when hover and to add the border as they suggested in a slack thread
|
MiriamAparicio
force-pushed
the
fix-button-background-visual-refresh
branch
from
7609e20 to
dc42b41
Compare
|
Hi @iblancof This is the final result agaist EUI PR, when they release the changes this is how it's going to look, no background on ::active or ::focus Screen.Recording.2025-05-26.at.10.12.14.mov |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
…astic#221366) ## Summary Related to [elastic#220620](elastic#220620) Following a review of the upcoming button visual refresh planned by the EUI team for early June, we identified an issue with the background styling on dropdown buttons within the Infrastructure Inventory view. <img width="496" alt="image" src="https://github.com/user-attachments/assets/5e293034-fd44-4d0e-824b-a66863c0ae8a" /> ### Changes Implemented - Removed the background from the dropdown button label. - Added a right border to improve visual clarity. These changes are safe to merge into `main` ahead of the EUI release, as they do not impact the current UI behavior.
3 participants
Summary
Related to elastic/kibana#220620
Following a review of the upcoming button visual refresh planned by the EUI team for early June, we identified an issue with the background styling on dropdown buttons within the Infrastructure Inventory view.
Changes Implemented
These changes are safe to merge into
mainahead of the EUI release, as they do not impact the current UI behavior.