Skip to content

[Detection Engine] Prevent test data from rolling outside of Cypress rules' query #220923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rylnd merged 9 commits into from
May 23, 2025
Merged

[Detection Engine] Prevent test data from rolling outside of Cypress rules' query #220923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6399aaf
Update cypress DE rules to query from a fixed (starting) time frame
rylnd May 21, 2025
c230ee9
Unskip tests failing due to stale test data
rylnd May 19, 2025
3ab213b
Remove one more instance of a rolling-windowed test
rylnd May 21, 2025
f878869
Unskip cypress tests failing due to rule not generating alerts
rylnd May 21, 2025
80901e8
Merge branch 'main' into rylnd/fix_outdated_test_data
rylnd May 21, 2025
4d93afa
Fix parameter typo
rylnd May 21, 2025
2563ef7
Set new_terms history window to 150 years
rylnd May 21, 2025
ce45e52
Remove tricky assertion from Indicator Match test
rylnd May 22, 2025
037a7b2
Use a more recent `from` for indicator match rules
rylnd May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...ion_engine/exceptions/alerts_table_flow/rule_exceptions/closing_all_matching_alerts.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ const getExceptionList1 = () => ({
list_id: 'exception_list_1',
});

// Failing: See https://github.com/elastic/kibana/issues/199905
// Failing: See https://github.com/elastic/kibana/issues/199905
describe.skip('Close matching Alerts ', { tags: ['@ess', '@serverless'] }, () => {
describe('Close matching Alerts ', { tags: ['@ess', '@serverless'] }, () => {
const ITEM_NAME = 'Sample Exception Item';

beforeEach(() => {
Expand Down
1 change: 0 additions & 1 deletion ..._cypress/cypress/e2e/detection_response/detection_engine/exceptions/entry/match_any.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ describe('Exceptions match_any', { tags: ['@ess', '@serverless'] }, () => {
index: ['auditbeat-exceptions-*'],
enabled: false,
query: '*',
from: 'now-438300h',
})
).then((rule) => visitRuleDetailsPage(rule.body.id, { tab: 'rule_exceptions' }));
cy.get(RULE_STATUS).should('have.text', '—');
Expand Down
5 changes: 1 addition & 4 deletions ...detection_response/detection_engine/exceptions/rule_details_flow/add_edit_exception.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ import {
} from '../../../../../tasks/api_calls/exceptions';
import { waitForAlertsToPopulate } from '../../../../../tasks/create_new_rule';

// TODO: https://github.com/elastic/kibana/issues/161539
// Failing: See https://github.com/elastic/kibana/issues/220822
// Failing: See https://github.com/elastic/kibana/issues/220822
describe.skip(
describe(
'Add/edit exception from rule details',
{ tags: ['@ess', '@serverless', '@skipInServerless'] },
() => {
Expand Down
3 changes: 1 addition & 2 deletions ...response/detection_engine/exceptions/rule_details_flow/add_edit_exception_data_view.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ import { waitForAlertsToPopulate } from '../../../../../tasks/create_new_rule';

const DATAVIEW = 'auditbeat-exceptions-*';

// Failing: See https://github.com/elastic/kibana/issues/207913
describe.skip(
describe(
'Add exception using data views from rule details',
{ tags: ['@ess', '@serverless'] },
() => {
Expand Down
10 changes: 1 addition & 9 deletions .../cypress/e2e/detection_response/detection_engine/rule_creation/indicator_match_rule.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { formatMitreAttackDescription, getHumanizedDuration } from '../../../../helpers/rules';
import { formatMitreAttackDescription } from '../../../../helpers/rules';
import {
getIndexPatterns,
getNewThreatIndicatorRule,
Expand All @@ -31,7 +31,6 @@ import {
ABOUT_DETAILS,
ABOUT_INVESTIGATION_NOTES,
ABOUT_RULE_DESCRIPTION,
ADDITIONAL_LOOK_BACK_DETAILS,
CUSTOM_QUERY_DETAILS,
DEFINITION_DETAILS,
FALSE_POSITIVES_DETAILS,
Expand Down Expand Up @@ -488,13 +487,6 @@ describe(
getDetails(RUNS_EVERY_DETAILS)
.find(INTERVAL_ABBR_VALUE)
.should('have.text', `${rule.interval}`);
const humanizedDuration = getHumanizedDuration(
rule.from ?? 'now-6m',
rule.interval ?? '5m'
);
getDetails(ADDITIONAL_LOOK_BACK_DETAILS)
.find(INTERVAL_ABBR_VALUE)
.should('have.text', `${humanizedDuration}`);
});

waitForTheRuleToBeExecuted();
Expand Down
38 changes: 19 additions & 19 deletions x-pack/test/security_solution_cypress/cypress/objects/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const getDataViewRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -153,7 +153,7 @@ export const getNewRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -168,7 +168,7 @@ export const getSavedQueryRule = (
name: 'New Rule Test',
description: 'The new rule description.',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
severity: 'low',
risk_score: 21,
...rewrites,
Expand All @@ -183,7 +183,7 @@ export const getSimpleCustomQueryRule = (
name: 'New Rule Test',
description: 'The new rule description.',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
severity: 'low',
risk_score: 21,
...rewrites,
Expand All @@ -205,7 +205,7 @@ export const getBuildingBlockRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
building_block_type: 'default',
...rewrites,
Expand All @@ -227,7 +227,7 @@ export const getUnmappedRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -248,7 +248,7 @@ export const getUnmappedCCSRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -269,7 +269,7 @@ export const getExistingRule = (
threat: [],
note: 'This is my note',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
// Please do not change, or if you do, needs
// to be any number other than default value
max_signals: 500,
Expand Down Expand Up @@ -303,7 +303,7 @@ export const getNewOverrideRule = (
rule_name_override: 'agent.type',
timestamp_override: '@timestamp',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -328,7 +328,7 @@ export const getNewThresholdRule = (
value: 1,
},
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -349,9 +349,9 @@ export const getNewTermsRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
new_terms_fields: ['host.name'],
history_window_start: 'now-51000h',
history_window_start: `now-${365 * 150}d`,
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -375,7 +375,7 @@ export const getMachineLearningRule = (
threat: [getMitre1()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
...rewrites,
});

Expand All @@ -396,7 +396,7 @@ export const getEqlRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -417,7 +417,7 @@ export const getEsqlRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -439,7 +439,7 @@ export const getCCSEqlRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -464,7 +464,7 @@ export const getEqlSequenceRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
...rewrites,
});
Expand All @@ -487,7 +487,7 @@ export const getNewThreatIndicatorRule = (
threat: [getMitre1(), getMitre2()],
note: '# test markdown',
interval: '100m',
from: 'now-50000h',
from: '2000-01-01T00:00:00.000Z',
threat_index: ['filebeat-*'],
threat_mapping: [
{
Expand Down Expand Up @@ -673,7 +673,7 @@ export const getEndpointRule = (): QueryRuleCreateProps => ({
severity: 'high',
risk_score: 17,
interval: '1m',
from: 'now-50000h',
from: '1900-01-01T00:00:00.000Z',
max_signals: 100,
exceptions_list: [
{
Expand Down