Skip to content

[8.19] fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing error warning announcement (#220633) #220663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
May 9, 2025
Merged

[8.19] fix: [Platform:StackManagement:SnapshotAndRestore:Add repository page]Missing error warning announcement (#220633) #220663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...shared/es_ui_shared/__packages_do_not_import__/authorization/components/section_error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const SectionError: React.FunctionComponent<Props> = ({
} = error;

return (
<EuiCallOut title={title} color="danger" iconType="warning" {...rest}>
<EuiCallOut title={title} role="alert" color="danger" iconType="warning" {...rest}>
{cause ? message || errorString : <p>{message || errorString}</p>}
{cause && (
<Fragment>
Expand Down
1 change: 1 addition & 0 deletions ...ivate/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ export const PolicyStepLogistics: React.FunctionComponent<StepProps> = ({
defaultMessage="Repository not found"
/>
}
role="alert"
color="danger"
iconType="warning"
>
Expand Down
1 change: 1 addition & 0 deletions ...ugins/private/snapshot_restore/public/application/components/repository_form/step_one.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ export const RepositoryFormStepOne: React.FunctionComponent<Props> = ({
defaultMessage="Fix errors before continuing."
/>
}
role="alert"
color="danger"
data-test-subj="repositoryFormError"
/>
Expand Down
1 change: 1 addition & 0 deletions ...ugins/private/snapshot_restore/public/application/components/repository_form/step_two.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ export const RepositoryFormStepTwo: React.FunctionComponent<Props> = ({
defaultMessage="Fix errors before continuing."
/>
}
role="alert"
color="danger"
iconType="cross"
data-test-subj="repositoryFormError"
Expand Down
7 changes: 5 additions & 2 deletions ...rivate/snapshot_restore/public/application/components/retention_update_modal_provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
EuiSpacer,
EuiText,
EuiCallOut,
useGeneratedHtmlId,
} from '@elastic/eui';

import { useCore, useServices, useToastNotifications } from '../app_context';
Expand All @@ -45,6 +46,7 @@ export const RetentionSettingsUpdateModalProvider: React.FunctionComponent<Props
const { i18n } = useServices();
const { docLinks } = useCore();
const toastNotifications = useToastNotifications();
const modalTitleId = useGeneratedHtmlId();

const [retentionSchedule, setRetentionSchedule] = useState<string>(DEFAULT_RETENTION_SCHEDULE);
const [isModalOpen, setIsModalOpen] = useState<boolean>(false);
Expand Down Expand Up @@ -128,9 +130,9 @@ export const RetentionSettingsUpdateModalProvider: React.FunctionComponent<Props
}

return (
<EuiModal onClose={closeModal}>
<EuiModal onClose={closeModal} aria-labelledby={modalTitleId}>
<EuiModalHeader>
<EuiModalHeaderTitle>
<EuiModalHeaderTitle id={modalTitleId}>
{isEditing ? (
<FormattedMessage
id="xpack.snapshotRestore.policyForm.stepRetention.policyUpdateRetentionEditTitle"
Expand All @@ -155,6 +157,7 @@ export const RetentionSettingsUpdateModalProvider: React.FunctionComponent<Props
defaultMessage="Error saving retention schedule"
/>
}
role="alert"
color="danger"
iconType="warning"
>
Expand Down
3 changes: 3 additions & 0 deletions ...ication/sections/home/policy_list/policy_retention_schedule/policy_retention_schedule.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export const PolicyRetentionSchedule: React.FunctionComponent<Props> = ({
defaultMessage="Run retention now"
/>
}
disableScreenReaderOutput
>
<EuiButtonIcon
iconType="play"
Expand Down Expand Up @@ -108,6 +109,7 @@ export const PolicyRetentionSchedule: React.FunctionComponent<Props> = ({
defaultMessage="Edit retention schedule"
/>
}
disableScreenReaderOutput
>
<EuiButtonIcon
iconType="pencil"
Expand Down Expand Up @@ -254,6 +256,7 @@ export const PolicyRetentionSchedule: React.FunctionComponent<Props> = ({
defaultMessage="Error fetching retention schedule"
/>
}
role="alert"
color="danger"
iconType="warning"
>
Expand Down
1 change: 1 addition & 0 deletions ...restore/public/application/sections/home/snapshot_list/components/snapshot_search_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export const SnapshotSearchBar: React.FunctionComponent<Props> = ({
<EuiCallOut
data-test-subj="snapshotListSearchError"
iconType="warning"
role="alert"
color="danger"
title={
<FormattedMessage
Expand Down