Skip to content

[8.17] [Obs AI Assistant] Use update-by-query for semantic_text migration (#220255) #220642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorenlouv merged 6 commits into from
May 14, 2025
Merged

[8.17] [Obs AI Assistant] Use update-by-query for semantic_text migration (#220255) #220642

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac17f35
[Obs AI Assistant] Use update-by-query for semantic_text migration (#…
sorenlouv May 8, 2025
aebc615
Replace recursive function with updateByQuery
sorenlouv May 9, 2025
6d8f56c
Update route.ts
sorenlouv May 9, 2025
d38bb09
Update index.ts
sorenlouv May 9, 2025
3853b7c
Merge branch '8.17' into backport/8.17/pr-220255
viduni94 May 12, 2025
b9a05a2
Add `refresh: true`
sorenlouv May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 20 additions & 56 deletions ...t/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
*/

import { ElasticsearchClient } from '@kbn/core-elasticsearch-server';
import pLimit from 'p-limit';
import { TaskManagerSetupContract } from '@kbn/task-manager-plugin/server';
import type { CoreSetup, Logger } from '@kbn/core/server';
import pRetry from 'p-retry';
import { KnowledgeBaseEntry } from '../../../common';
import { resourceNames } from '..';
import { getElserModelStatus } from '../inference_endpoint';
import { ObservabilityAIAssistantPluginStartDependencies } from '../../types';
Expand Down Expand Up @@ -104,64 +102,30 @@ export async function runSemanticTextKnowledgeBaseMigration({
logger: Logger;
config: ObservabilityAIAssistantConfig;
}) {
logger.debug('Knowledge base migration: Running migration');
logger.debug('Initalizing semantic text migration for knowledge base entries...');

try {
const response = await esClient.asInternalUser.search<KnowledgeBaseEntry>({
size: 100,
track_total_hits: true,
index: [resourceNames.aliases.kb],
query: {
bool: {
must_not: {
exists: {
field: 'semantic_text',
},
},
await pRetry(
async () => {
await waitForModel({ esClient, logger, config });
await esClient.asInternalUser.updateByQuery({
index: [resourceNames.aliases.kb],
requests_per_second: 100,
refresh: true,
script: {
source: `ctx._source.semantic_text = ctx._source.text`,
lang: 'painless',
},
},
_source: {
excludes: ['ml.tokens'],
},
});

if (response.hits.hits.length === 0) {
logger.debug('Knowledge base migration: No remaining entries to migrate');
return;
}

logger.debug(`Knowledge base migration: Found ${response.hits.hits.length} entries to migrate`);

await waitForModel({ esClient, logger, config });

// Limit the number of concurrent requests to avoid overloading the cluster
const limiter = pLimit(10);
const promises = response.hits.hits.map((hit) => {
return limiter(() => {
if (!hit._source || !hit._id) {
return;
}

return esClient.asInternalUser.update({
refresh: 'wait_for',
index: resourceNames.aliases.kb,
id: hit._id,
body: {
doc: {
...hit._source,
semantic_text: hit._source.text,
},
query: {
bool: {
filter: { exists: { field: 'text' } },
must_not: { exists: { field: 'semantic_text' } },
},
});
},
});
});

await Promise.all(promises);
logger.debug(`Knowledge base migration: Migrated ${promises.length} entries`);
await runSemanticTextKnowledgeBaseMigration({ esClient, logger, config });
} catch (e) {
logger.error(`Knowledge base migration failed: ${e.message}`);
}
},
{ retries: 10, minTimeout: 10_000 }
);
logger.debug('Semantic text migration completed successfully.');
}

async function waitForModel({
Expand Down