Skip to content

[Security Solution] Enforce sending the request to API even if offline, for air-gapped environment. #220510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkelas merged 12 commits into from
Jun 10, 2025
Merged

[Security Solution] Enforce sending the request to API even if offline, for air-gapped environment. #220510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6628459
Enforce the request even if offline, for air-gapped environment.
May 7, 2025
1371bdd
Suggestion from review
May 20, 2025
91f07d3
Merge branch 'main' into 181808_air_gapped_2
May 23, 2025
bee09e3
Merge branch 'main' into 181808_air_gapped_2
May 26, 2025
08b23b2
Merge branch 'main' into 181808_air_gapped_2
May 28, 2025
e7f8ae7
Merge branch 'main' into 181808_air_gapped_2
Jun 2, 2025
25fe947
Merge branch 'main' into 181808_air_gapped_2
Jun 3, 2025
13628cd
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
kibanamachine Jun 3, 2025
ed0f13d
[CI] Auto-commit changed files from 'make api-docs'
kibanamachine Jun 3, 2025
9a16698
Merge branch 'main' into 181808_air_gapped_2
Jun 5, 2025
d727eb4
Merge branch 'main' into 181808_air_gapped_2
Jun 5, 2025
c30d480
Merge branch 'main' into 181808_air_gapped_2
Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion x-pack/platform/plugins/shared/cases/public/components/cases_context/query_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,13 @@

import { QueryClient } from '@tanstack/react-query';

export const casesQueryClient = new QueryClient();
export const casesQueryClient = new QueryClient({
defaultOptions: {
queries: {
networkMode: 'always',
},
mutations: {
networkMode: 'always',
},
},
});
11 changes: 10 additions & 1 deletion x-pack/platform/plugins/shared/fleet/public/applications/fleet/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,16 @@ import { DebugPage } from './sections/debug';

const FEEDBACK_URL = 'https://ela.st/fleet-feedback';

const queryClient = new QueryClient();
const queryClient = new QueryClient({
Copy link
Copy Markdown
Member

@nchaulet nchaulet May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! We have a second client in Fleet for the integration app, it probably should have the same treatment https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/fleet/public/applications/integrations/app.tsx#L49

Copy link
Copy Markdown
Contributor Author

@jkelas jkelas May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchaulet I implemented your remark, please take a look

defaultOptions: {
queries: {
networkMode: 'always',
},
mutations: {
networkMode: 'always',
},
},
});

export const WithPermissionsAndSetup = memo<{ children?: React.ReactNode }>(({ children }) => {
useBreadcrumbs('base');
Expand Down
11 changes: 10 additions & 1 deletion x-pack/platform/plugins/shared/fleet/public/applications/integrations/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,16 @@ import { IntegrationsHeader } from './components/header';
import { AgentEnrollmentFlyout } from './components';
import { ReadOnlyContextProvider } from './hooks/use_read_only_context';

const queryClient = new QueryClient();
const queryClient = new QueryClient({
defaultOptions: {
queries: {
networkMode: 'always',
},
mutations: {
networkMode: 'always',
},
},
});

const EmptyContext = () => <></>;

Expand Down
6 changes: 5 additions & 1 deletion ...plugins/security_solution/public/common/containers/query_client/query_client_provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ export class SecuritySolutionQueryClient extends QueryClient {
refetchOnWindowFocus: false,
refetchOnMount: true,
keepPreviousData: true,
...(options?.defaultOptions?.queries ?? {}),
...(options?.defaultOptions?.queries ?? { networkMode: 'always' }),
},
mutations: {
networkMode: 'always',
...(options?.defaultOptions?.mutations ?? { networkMode: 'always' }),
},
},
};
Expand Down
Loading