[Platform security] Replace SCSS with CSS in JS (part 2)#220508
Closed
SiddharthMantri wants to merge 26 commits intoelastic:mainfrom
Closed
[Platform security] Replace SCSS with CSS in JS (part 2)#220508SiddharthMantri wants to merge 26 commits intoelastic:mainfrom
SiddharthMantri wants to merge 26 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
ryankeairns
approved these changes
May 19, 2025
kc13greiner
reviewed
May 19, 2025
| return ( | ||
| <div className="interactiveSetup"> | ||
| <header className="interactiveSetup__header eui-textCenter"> | ||
| <div css={fullScreenGraphicsMixinStyles(Number(euiTheme.levels.navigation), theme)}> |
Contributor
Contributor
Author
There was a problem hiding this comment.
@kc13greiner - That's right! I need to get this fixed and get the CI to pass
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
miscellaneous assets size
History
|
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
Closing in favor of #233508 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #211652
Summary
Part 2 of #211652 and follow up from #214798
Removed most SASS files from all platform security owned code. (Full checklist on parent issue)
How to test
Testing visual regression isn't super straightforward here. For my local testing, i started two instances of Kibana (main and this branch)
On main:
Once started, in a private browsing window, you should have access to Kibana on main on
localhost:5602On this PR:
Start ES and Kibana normally (Kibana should be available on localhost:5601)
This PR contains changes to the following parts of the Spaces plugin:
For testing the full login page with different selectors, etc, you can start kibana with the following changes in the kibana.dev.yml file
Ideally, you should see no visual regression between the two versions.
Screenshots
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.