[8.19] [Obs AI Assistant] Remove index write blocks (#220362)#220507
Merged
sorenlouv merged 1 commit intoelastic:8.19from May 8, 2025
Merged
[8.19] [Obs AI Assistant] Remove index write blocks (#220362)#220507sorenlouv merged 1 commit intoelastic:8.19from
sorenlouv merged 1 commit intoelastic:8.19from
Conversation
Closes elastic#220248 - This PR removes the write index blocks that were previously added when starting a reindex operation. The index blocks were added to prevent writes to the source index, while it was being re-indexed to a target index. - Re-enables tests to run on MKI Why index blocks should be removed: - Immediately after creating the target index, the KB write index alias is pointed over to the new target index. This means that it is possible to ingest documents to the new target index, while the re-index is in progress. Thus, we no longer need to block writes - Index blocks must be cleaned up. If a node crashes after a re-index operation has been started, the reindex operation itself will continue to run because it is handled by Elasticsearch with all the guarantees it provides. However, the index block will not be removed again, causing a permanent dead lock until customers remove the index block themselves. Customers should not end up in this situation. - Index blocks are causing tests to fail, when the index block is not properly cleaned up afterwards: elastic#220248 --------- Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co> Co-authored-by: Viduni Wickramarachchi <viduni.ushanka@gmail.com> (cherry picked from commit 3c95148) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_basic_operations.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_change_model_from_elser_to_e5.spec.ts # x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_status.spec.ts
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
viduni94
approved these changes
May 8, 2025
Contributor
💚 Build Succeeded
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation