Skip to content

[Obs AI Assistant] Make API tests more resilient#220503

Merged
sorenlouv merged 2 commits intoelastic:mainfrom
sorenlouv:fix-failing-mki-tests
May 8, 2025
Merged

[Obs AI Assistant] Make API tests more resilient#220503
sorenlouv merged 2 commits intoelastic:mainfrom
sorenlouv:fix-failing-mki-tests

Conversation

@sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented May 8, 2025 •
edited by kibanamachine
Loading

This PR aims to make API test more resilient by improving logging and utilities gracefully handling known errors.

sorenlouv
sorenlouv commented May 8, 2025
View reviewed changes
...ervability_ai_assistant/server/service/knowledge_base_service/create_knowledge_base_index.ts
Comment on lines -26 to +24
await esClient.asInternalUser.indices.create({
index: indexName,
mappings: {
properties: {
semantic_text: {
type: 'semantic_text',
inference_id: inferenceId,
},
},
},
});
await esClient.asInternalUser.indices.create({ index: indexName });
Copy link
Member Author

@sorenlouv sorenlouv May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viduni94 I think this was leftover from #218448. We don't need to add the inference id to the index, since we already update the component template.

Copy link
Contributor

@viduni94 viduni94 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, thanks for updating this @sorenlouv 🙏🏻

@sorenlouv sorenlouv marked this pull request as ready for review May 8, 2025 12:39
@sorenlouv sorenlouv requested a review from a team as a code owner May 8, 2025 12:39
@elasticmachine
Copy link
Contributor

elasticmachine commented May 8, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 394 393 -1
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 396 395 -1

@kibanamachine
Copy link
Contributor

kibanamachine commented May 8, 2025

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#8253

[❌] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 99/100 tests passed.
[❌] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.ai_assistant.serverless.config.ts: 75/100 tests passed.

see run history

viduni94
viduni94 approved these changes May 8, 2025
View reviewed changes
...loyment_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_setup.spec.ts

before(async () => {
// setup KB initially

Copy link
Contributor

@viduni94 viduni94 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels May 8, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented May 8, 2025

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv merged commit 3743f7d into elastic:main May 8, 2025
22 checks passed
@sorenlouv sorenlouv deleted the fix-failing-mki-tests branch May 8, 2025 17:45
@kibanamachine
Copy link
Contributor

kibanamachine commented May 8, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14912713385

@kibanamachine
Copy link
Contributor

kibanamachine commented May 8, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 220503

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request May 8, 2025
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request May 8, 2025
@sorenlouv
[Obs AI Assistant] Make API tests more resilient (elastic#220503)
cfd3362 
This PR aims to make API test more resilient by improving logging and
utilities gracefully handling known errors.

(cherry picked from commit 3743f7d)
@sorenlouv sorenlouv mentioned this pull request May 8, 2025
Merged
@sorenlouv
Copy link
Member Author

sorenlouv commented May 8, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request May 8, 2025
Merged
sorenlouv added a commit that referenced this pull request May 8, 2025
@sorenlouv
[8.19] [Obs AI Assistant] Make API tests more resilient (#220503) (#2…
0d7f85b 
…20565)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Obs AI Assistant] Make API tests more resilient
(#220503)](#220503)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-05-08T17:45:18Z","message":"[Obs
AI Assistant] Make API tests more resilient (#220503)\n\nThis PR aims to
make API test more resilient by improving logging and\nutilities
gracefully handling known
errors.","sha":"3743f7d46598407a80030297531deb48707cfcda","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Make API tests more
resilient","number":220503,"url":"https://github.com/elastic/kibana/pull/220503","mergeCommit":{"message":"[Obs
AI Assistant] Make API tests more resilient (#220503)\n\nThis PR aims to
make API test more resilient by improving logging and\nutilities
gracefully handling known
errors.","sha":"3743f7d46598407a80030297531deb48707cfcda"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220503","number":220503,"mergeCommit":{"message":"[Obs
AI Assistant] Make API tests more resilient (#220503)\n\nThis PR aims to
make API test more resilient by improving logging and\nutilities
gracefully handling known
errors.","sha":"3743f7d46598407a80030297531deb48707cfcda"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
kdelemme pushed a commit to kdelemme/kibana that referenced this pull request May 9, 2025
@sorenlouv @kdelemme
[Obs AI Assistant] Make API tests more resilient (elastic#220503)
3482196 
This PR aims to make API test more resilient by improving logging and
utilities gracefully handling known errors.
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@sorenlouv @akowalska622
[Obs AI Assistant] Make API tests more resilient (elastic#220503)
2d65c01 
This PR aims to make API test more resilient by improving logging and
utilities gracefully handling known errors.
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@sorenlouv @qn895
[Obs AI Assistant] Make API tests more resilient (elastic#220503)
2fa7525 
This PR aims to make API test more resilient by improving logging and
utilities gracefully handling known errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viduni94 viduni94 viduni94 approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:fix Team:Obs AI Assistant Observability AI Assistant v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sorenlouv @elasticmachine @kibanamachine @viduni94