[LockManager] Update token and metadata when an expired lock is re-acquired#220476
Merged
sorenlouv merged 1 commit intoelastic:mainfrom May 8, 2025
Merged
[LockManager] Update token and metadata when an expired lock is re-acquired#220476sorenlouv merged 1 commit intoelastic:mainfrom
sorenlouv merged 1 commit intoelastic:mainfrom
Conversation
sorenlouv
added
backport:version
sorenlouv
force-pushed
the
lock-manager-update-token
branch
from
8d2ba24 to
980f96f
Compare
viduni94
approved these changes
May 8, 2025
Contributor
|
Starting backport for target branches: 8.19 https://github.com/elastic/kibana/actions/runs/14912628323 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2025
…quired (elastic#220476) Related: elastic#216397 This fixes a bug in the Lock Manager where an expired lock can be acquired, but the token and metadata is not updated. This means that the lock cannot be released. Instead it is automatically released when the TTL expires. (cherry picked from commit 74e876d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2025
…s re-acquired (#220476) (#220554) # Backport This will backport the following commits from `main` to `8.19`: - [[LockManager] Update token and metadata when an expired lock is re-acquired (#220476)](#220476) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-05-08T17:40:20Z","message":"[LockManager] Update token and metadata when an expired lock is re-acquired (#220476)\n\nRelated: https://github.com/elastic/kibana/pull/216397\n\nThis fixes a bug in the Lock Manager where an expired lock can be\nacquired, but the token and metadata is not updated. This means that the\nlock cannot be released. Instead it is automatically released when the\nTTL expires.","sha":"74e876d12d5a9927d63d41702778cd42e7deec80","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[LockManager] Update token and metadata when an expired lock is re-acquired","number":220476,"url":"https://github.com/elastic/kibana/pull/220476","mergeCommit":{"message":"[LockManager] Update token and metadata when an expired lock is re-acquired (#220476)\n\nRelated: https://github.com/elastic/kibana/pull/216397\n\nThis fixes a bug in the Lock Manager where an expired lock can be\nacquired, but the token and metadata is not updated. This means that the\nlock cannot be released. Instead it is automatically released when the\nTTL expires.","sha":"74e876d12d5a9927d63d41702778cd42e7deec80"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220476","number":220476,"mergeCommit":{"message":"[LockManager] Update token and metadata when an expired lock is re-acquired (#220476)\n\nRelated: https://github.com/elastic/kibana/pull/216397\n\nThis fixes a bug in the Lock Manager where an expired lock can be\nacquired, but the token and metadata is not updated. This means that the\nlock cannot be released. Instead it is automatically released when the\nTTL expires.","sha":"74e876d12d5a9927d63d41702778cd42e7deec80"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
kdelemme
pushed a commit
to kdelemme/kibana
that referenced
this pull request
May 9, 2025
…quired (elastic#220476) Related: elastic#216397 This fixes a bug in the Lock Manager where an expired lock can be acquired, but the token and metadata is not updated. This means that the lock cannot be released. Instead it is automatically released when the TTL expires.
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…quired (elastic#220476) Related: elastic#216397 This fixes a bug in the Lock Manager where an expired lock can be acquired, but the token and metadata is not updated. This means that the lock cannot be released. Instead it is automatically released when the TTL expires.
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…quired (elastic#220476) Related: elastic#216397 This fixes a bug in the Lock Manager where an expired lock can be acquired, but the token and metadata is not updated. This means that the lock cannot be released. Instead it is automatically released when the TTL expires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #216397
This fixes a bug in the Lock Manager where an expired lock can be acquired, but the token and metadata is not updated. This means that the lock cannot be released. Instead it is automatically released when the TTL expires.