Skip to content

[9.0] Update Elasticsearch URLs in doc link service (#219656) #220450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcawl merged 4 commits into from
May 9, 2025
Merged

[9.0] Update Elasticsearch URLs in doc link service (#219656) #220450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b418a63
Update Elasticsearch URLs in doc link service (#219656)
lcawl May 7, 2025
381380c
Merge branch '9.0' into backport/9.0/pr-219656
lcawl May 8, 2025
dba7915
Merge branch '9.0' into backport/9.0/pr-219656
lcawl May 9, 2025
73056d6
Merge branch '9.0' into backport/9.0/pr-219656
lcawl May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
376 changes: 192 additions & 184 deletions src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions src/platform/plugins/shared/data/server/ui_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,7 @@ export function getUiSettings(
},
[UI_SETTINGS.SEARCH_INCLUDE_FROZEN]: {
name: 'Search in frozen indices',
description: `Will include <a href=${docLinks.links.elasticsearch.frozenIndices}
target="_blank" rel="noopener">frozen indices</a> in results if enabled. Searching through frozen indices
description: `Will include frozen indices in results if enabled. Searching through frozen indices
might increase the search time.`,
value: false,
deprecation: {
Expand Down
8 changes: 2 additions & 6 deletions ...dex_management/__jest__/client_integration/index_details_page/index_details_page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,9 +643,7 @@ describe('<IndexDetailsPage />', () => {
it('sets the docs link href from the documentation service', async () => {
const docsLinkHref = testBed.actions.mappings.getDocsLinkHref();
// the url from the mocked docs mock
expect(docsLinkHref).toEqual(
'https://www.elastic.co/guide/en/elasticsearch/reference/mocked-test-branch/mapping.html'
);
expect(docsLinkHref).toContain('mapping');
});
describe('Filter field by filter Type', () => {
const mockIndexMappingResponse: any = {
Expand Down Expand Up @@ -1021,9 +1019,7 @@ describe('<IndexDetailsPage />', () => {
await testBed.actions.clickIndexDetailsTab(IndexDetailsSection.Settings);
const docsLinkHref = testBed.actions.settings.getDocsLinkHref();
// the url from the mocked docs mock
expect(docsLinkHref).toEqual(
'https://www.elastic.co/guide/en/elasticsearch/reference/mocked-test-branch/index-modules.html#index-modules-settings'
);
expect(docsLinkHref).toContain('index-modules');
});

describe('error loading settings', () => {
Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/functional/apps/dataset_quality/degraded_field_flyout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid

const linkURL = await linkButton.getAttribute('href');

expect(linkURL?.endsWith('mapping-settings-limit.html')).to.be(true);
expect(linkURL?.includes('mapping')).to.be(true);
});

it('should display increase field limit as a possible mitigation for special packages like apm app', async () => {
Expand Down Expand Up @@ -829,7 +829,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid

const linkURL = await linkButton.getAttribute('href');

expect(linkURL?.endsWith('mapping-settings-limit.html')).to.be(true);
expect(linkURL?.includes('mapping')).to.be(true);
});

it('should display increase field limit as a possible mitigation for non integration', async () => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test_serverless/functional/page_objects/svl_search_elasticsearch_start_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export function SvlSearchElasticsearchStartPageProvider({ getService }: FtrProvi
async expectAnalyzeLogsLink() {
await testSubjects.existOrFail('analyzeLogsBtn');
expect(await testSubjects.getAttribute('analyzeLogsBtn', 'href')).equal(
'https://www.elastic.co/guide/en/serverless/current/elasticsearch-ingest-your-data.html'
'https://www.elastic.co/docs/manage-data/ingest'
);
expect(await testSubjects.getAttribute('analyzeLogsBtn', 'target')).equal('_blank');
},
Expand Down
4 changes: 2 additions & 2 deletions ..._serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

const linkURL = await linkButton.getAttribute('href');

expect(linkURL?.endsWith('mapping-settings-limit.html')).to.be(true);
expect(linkURL?.includes('mapping')).to.be(true);
});

it('should display increase field limit as a possible mitigation for special packages like apm app', async () => {
Expand Down Expand Up @@ -849,7 +849,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

const linkURL = await linkButton.getAttribute('href');

expect(linkURL?.endsWith('mapping-settings-limit.html')).to.be(true);
expect(linkURL?.includes('mapping')).to.be(true);
});

it('should display increase field limit as a possible mitigation for non integration', async () => {
Expand Down