Fix color and static lookup field formatters not loading#22044
Merged
jen-huang merged 1 commit intoelastic:masterfrom Aug 16, 2018
Merged
Fix color and static lookup field formatters not loading#22044jen-huang merged 1 commit intoelastic:masterfrom
jen-huang merged 1 commit intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Aug 16, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally and works as expected. Code looks great. Thanks for explaining these changes to me!
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Aug 16, 2018
jen-huang
added a commit
that referenced
this pull request
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20525 wrapped
colorandstatic_lookupfield format editor components withinjectI18n(). This created new components that don't have theformatIdproperty, which is used to identify which editor to load. When the user selectsColororStatic lookupin the field editor UI, no additional inputs are shown.This PR resolves the issue by adding
formatIdto the i18n component. Also adds additional tests to all field format editors to ensure thatformatIdis present./cc @maryia-lapata